Fixes #1888 better honors repo detection setting

Author: eamodio

CHANGELOG.md

@@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 
 ### Fixed
 
+- Fixes [#1888](https://github.com/gitkraken/vscode-gitlens/issues/1888) - Gitlens breaks vscode auto repository detection settings
 - Fixes an issue where the Visual File History wasn't correctly opening the commit file details quick pick menu
 - Fixes an issue where the _Open Visual File History of Active File_ command wasn't showing in the Command Palette
 

src/env/node/git/localGitProvider.ts

@@ -376,7 +376,10 @@ export class LocalGitProvider implements GitProvider, Disposable {
 		suspended?: boolean,
 		closed?: boolean,
 	): Repository {
-		void this.openScmRepository(uri);
+		if (!closed) {
+			void this.openScmRepository(uri);
+		}
+
 		return new Repository(
 			this.container,
 			this.onRepositoryChanged.bind(this),

src/git/gitProviderService.ts

@@ -1850,8 +1850,15 @@ export class GitProviderService implements Disposable {
 				// If this new repo is inside one of our known roots and we we don't already know about, add it
 				const root = this._repositories.getClosest(provider.getAbsoluteUri(uri, repoUri));
 
+				const autoRepositoryDetection =
+					configuration.getAny<boolean | 'subFolders' | 'openEditors'>(
+						CoreGitConfiguration.AutoRepositoryDetection,
+					) ?? true;
+
+				const closed = autoRepositoryDetection !== true && autoRepositoryDetection !== 'openEditors';
+
 				Logger.log(cc, `Repository found in '${repoUri.toString(false)}'`);
-				repository = provider.openRepository(root?.folder, repoUri, false);
+				repository = provider.openRepository(root?.folder, repoUri, false, undefined, closed);
 				this._repositories.add(repository);
 
 				this._pendingRepositories.delete(key);