Skip to content

Commit e063b2f

Browse files
Sends attempted integration ids in connected event
1 parent fb457b3 commit e063b2f

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

src/constants.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1220,8 +1220,8 @@ export type StoredFocusGroup =
12201220
| 'snoozed';
12211221

12221222
export type TelemetryGlobalContext = {
1223-
'cloudIntegrations.connectedCount': number;
1224-
'cloudIntegrations.connectedIds': string;
1223+
'cloudIntegrations.connected.count': number;
1224+
'cloudIntegrations.connected.ids': string;
12251225
debugging: boolean;
12261226
enabled: boolean;
12271227
prerelease: boolean;
@@ -1277,6 +1277,7 @@ export type TelemetryEvents = {
12771277
/** Sent when connected to one or more cloud-based integrations from gkdev*/
12781278
'cloudIntegrations/connected': {
12791279
'integration.ids': string | undefined;
1280+
'integration.connected.ids': string | undefined;
12801281
};
12811282

12821283
/** Sent when a cloud-based hosting provider is connected */

src/plus/integrations/integrationService.ts

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,8 @@ export class IntegrationService implements Disposable {
112112

113113
if (this.container.telemetry.enabled) {
114114
this.container.telemetry.setGlobalAttributes({
115-
'cloudIntegrations.connectedCount': connectedIntegrations.size,
116-
'cloudIntegrations.connectedIds': join(connectedIntegrations.values(), ','),
115+
'cloudIntegrations.connected.count': connectedIntegrations.size,
116+
'cloudIntegrations.connected.ids': join(connectedIntegrations.values(), ','),
117117
});
118118
}
119119

@@ -168,7 +168,10 @@ export class IntegrationService implements Disposable {
168168
if (this.container.telemetry.enabled) {
169169
this.container.telemetry.sendEvent(
170170
'cloudIntegrations/connected',
171-
{ 'integration.ids': connected ? join(connected.values(), ',') : undefined },
171+
{
172+
'integration.ids': undefined,
173+
'integration.connected.ids': connected ? join(connected.values(), ',') : undefined,
174+
},
172175
source,
173176
);
174177
}
@@ -293,7 +296,10 @@ export class IntegrationService implements Disposable {
293296
if (this.container.telemetry.enabled) {
294297
this.container.telemetry.sendEvent(
295298
'cloudIntegrations/connected',
296-
{ 'integration.ids': connected ? join(connected.values(), ',') : undefined },
299+
{
300+
'integration.ids': integrationIds?.join(','),
301+
'integration.connected.ids': connected ? join(connected.values(), ',') : undefined,
302+
},
297303
source,
298304
);
299305
}

0 commit comments

Comments
 (0)