Stops header collapse on learn more

Author: eamodio

src/ui/settings/app.ts

@@ -12,10 +12,13 @@ export class SettingsApp extends App {
         super.bind();
 
         const onSectionHeaderClicked = this.onSectionHeaderClicked.bind(this);
-        DOM.listenAll('.section__header', 'click', function(this: HTMLInputElement) { onSectionHeaderClicked(this); });
+        DOM.listenAll('.section__header', 'click', function(this: HTMLInputElement) { return onSectionHeaderClicked(this, ...arguments); });
     }
 
-    private onSectionHeaderClicked(element: HTMLElement) {
+    private onSectionHeaderClicked(element: HTMLElement, e: MouseEvent) {
+        if ((e.target as HTMLElement).matches('i.icon__info') ||
+            (e.target as HTMLElement).matches('a.link__learn-more')) return;
+
         element.classList.toggle('collapsed');
     }
 }

src/ui/settings/index.html

@@ -46,7 +46,7 @@ <h2 class="page-header__title">Settings</h2>
                     <section id="gitlens-explorer">
                         <div class="section__header">
                             <h2 class="section__title">GitLens Explorer
-                                <a title="Learn more" href="https://github.com/eamodio/vscode-gitlens/tree/develop#gitlens-explorer">
+                                <a class="link__learn-more" title="Learn more" href="https://github.com/eamodio/vscode-gitlens/tree/develop#gitlens-explorer">
                                     <i class="icon icon__info"></i>
                                 </a>
                             </h2>
@@ -121,7 +121,7 @@ <h2 class="section__title">GitLens Explorer
                     <section id="gitlens-results">
                         <div class="section__header">
                             <h2 class="section__title">GitLens Results
-                                <a title="Learn more" href="https://github.com/eamodio/vscode-gitlens/tree/develop#gitlens-results-view">
+                                <a class="link__learn-more" title="Learn more" href="https://github.com/eamodio/vscode-gitlens/tree/develop#gitlens-results-view">
                                     <i class="icon icon__info"></i>
                                 </a>
                             </h2>
@@ -166,7 +166,7 @@ <h2 class="section__title">GitLens Results
                     <section id="code-lens">
                         <div class="section__header">
                             <h2 class="section__title">Code Lens
-                                <a title="Learn more" href="https://github.com/eamodio/vscode-gitlens/tree/develop#code-lens">
+                                <a class="link__learn-more" title="Learn more" href="https://github.com/eamodio/vscode-gitlens/tree/develop#code-lens">
                                     <i class="icon icon__info"></i>
                                 </a>
                             </h2>
@@ -257,7 +257,7 @@ <h2 class="section__title">Code Lens
                     <section id="current-line">
                         <div class="section__header">
                             <h2 class="section__title">Current Line Blame
-                                <a title="Learn more" href="https://github.com/eamodio/vscode-gitlens/tree/develop#current-line-blame">
+                                <a class="link__learn-more" title="Learn more" href="https://github.com/eamodio/vscode-gitlens/tree/develop#current-line-blame">
                                     <i class="icon icon__info"></i>
                                 </a>
                             </h2>
@@ -290,7 +290,7 @@ <h2 class="section__title">Current Line Blame
                     <section id="blame">
                         <div class="section__header">
                             <h2 class="section__title">Gutter Blame
-                                <a title="Learn more" href="https://github.com/eamodio/vscode-gitlens/tree/develop#gutter-blame">
+                                <a class="link__learn-more" title="Learn more" href="https://github.com/eamodio/vscode-gitlens/tree/develop#gutter-blame">
                                     <i class="icon icon__info"></i>
                                 </a>
                             </h2>
@@ -365,7 +365,7 @@ <h2 class="section__title">Gutter Blame
                     <section id="hovers">
                         <div class="section__header">
                             <h2 class="section__title">Hovers
-                                <a title="Learn more" href="https://github.com/eamodio/vscode-gitlens/tree/develop#hovers">
+                                <a class="link__learn-more" title="Learn more" href="https://github.com/eamodio/vscode-gitlens/tree/develop#hovers">
                                     <i class="icon icon__info"></i>
                                 </a>
                             </h2>
@@ -468,7 +468,7 @@ <h2 class="section__title">Hovers
                     <section id="recent-changes">
                         <div class="section__header">
                             <h2 class="section__title">Recent Changes
-                                <a title="Learn more" href="https://github.com/eamodio/vscode-gitlens/tree/develop#recent-changes">
+                                <a class="link__learn-more" title="Learn more" href="https://github.com/eamodio/vscode-gitlens/tree/develop#recent-changes">
                                     <i class="icon icon__info"></i>
                                 </a>
                             </h2>
@@ -509,7 +509,7 @@ <h2 class="section__title">Recent Changes
                     <section id="status-bar">
                         <div class="section__header">
                             <h2 class="section__title">Status Bar Blame
-                                <a title="Learn more" href="https://github.com/eamodio/vscode-gitlens/tree/develop#status-bar-blame">
+                                <a class="link__learn-more" title="Learn more" href="https://github.com/eamodio/vscode-gitlens/tree/develop#status-bar-blame">
                                     <i class="icon icon__info"></i>
                                 </a>
                             </h2>

src/ui/shared/app-base.ts

@@ -63,10 +63,10 @@ export abstract class App {
 
     protected bind() {
         const onInputChecked = this.onInputChecked.bind(this);
-        DOM.listenAll('input[type="checkbox"].setting', 'change', function(this: HTMLInputElement) { onInputChecked(this); });
+        DOM.listenAll('input[type="checkbox"].setting', 'change', function(this: HTMLInputElement) { return onInputChecked(this, ...arguments); });
 
         const onInputSelected = this.onInputSelected.bind(this);
-        DOM.listenAll('select.setting', 'change', function(this: HTMLInputElement) { onInputSelected(this); });
+        DOM.listenAll('select.setting', 'change', function(this: HTMLInputElement) { return onInputSelected(this, ...arguments); });
     }
 
     protected log(message: string) {