Fixes error logging args

Author: eamodio

src/plus/gk/account/organizationService.ts

@@ -79,7 +79,11 @@ export class OrganizationService implements Disposable {
 
 			if (!rsp.ok) {
 				debugger;
-				Logger.error('', scope, `Unable to get organizations; status=(${rsp.status}): ${rsp.statusText}`);
+				Logger.error(
+					undefined,
+					scope,
+					`Unable to get organizations; status=(${rsp.status}): ${rsp.statusText}`,
+				);
 
 				void window.showErrorMessage(`Unable to get organizations; Status: ${rsp.statusText}`, 'OK');
 

src/plus/gk/account/subscriptionService.ts

@@ -1499,7 +1499,7 @@ export class SubscriptionService implements Disposable {
 		}
 
 		if (code == null) {
-			Logger.error(`No code provided. Link: ${uri.toString(true)}`, scope);
+			Logger.error(undefined, scope, `No code provided. Link: ${uri.toString(true)}`);
 			void window.showErrorMessage(
 				`Unable to ${contextMessage} with that link. Please try clicking the link again. If this issue persists, please contact support.`,
 			);

src/plus/integrations/authentication/cloudIntegrationService.ts

@@ -1,5 +1,6 @@
 import type { Container } from '../../../container';
 import { Logger } from '../../../system/logger';
+import { getLogScope } from '../../../system/logger.scope';
 import type { ServerConnection } from '../../gk/serverConnection';
 import type { IntegrationId } from '../providers/models';
 import type { CloudIntegrationAuthenticationSession, CloudIntegrationConnection } from './models';
@@ -12,6 +13,8 @@ export class CloudIntegrationService {
 	) {}
 
 	async getConnections(): Promise<CloudIntegrationConnection[] | undefined> {
+		const scope = getLogScope();
+
 		const providersRsp = await this.connection.fetchGkDevApi(
 			'v1/provider-tokens',
 			{ method: 'GET' },
@@ -22,7 +25,7 @@ export class CloudIntegrationService {
 			const errorMessage =
 				typeof error === 'string' ? error : (error?.message as string) ?? providersRsp.statusText;
 			if (error != null) {
-				Logger.error(`Failed to get connected providers from cloud: ${errorMessage}`);
+				Logger.error(undefined, scope, `Failed to get connected providers from cloud: ${errorMessage}`);
 			}
 			if (this.container.telemetry.enabled) {
 				this.container.telemetry.sendEvent('cloudIntegrations/getConnections/failed', {
@@ -39,10 +42,12 @@ export class CloudIntegrationService {
 		id: IntegrationId,
 		refreshToken?: string,
 	): Promise<CloudIntegrationAuthenticationSession | undefined> {
+		const scope = getLogScope();
+
 		const refresh = Boolean(refreshToken);
 		const cloudIntegrationType = toCloudIntegrationType[id];
 		if (cloudIntegrationType == null) {
-			Logger.error(`Unsupported cloud integration type: ${id}`);
+			Logger.error(undefined, scope, `Unsupported cloud integration type: ${id}`);
 			return undefined;
 		}
 		const reqInitOptions = refreshToken
@@ -63,7 +68,11 @@ export class CloudIntegrationService {
 			const error = (await tokenRsp.json())?.error;
 			const errorMessage = typeof error === 'string' ? error : (error?.message as string) ?? tokenRsp.statusText;
 			if (error != null) {
-				Logger.error(`Failed to ${refresh ? 'refresh' : 'get'} ${id} token from cloud: ${errorMessage}`);
+				Logger.error(
+					undefined,
+					scope,
+					`Failed to ${refresh ? 'refresh' : 'get'} ${id} token from cloud: ${errorMessage}`,
+				);
 			}
 			if (this.container.telemetry.enabled) {
 				this.container.telemetry.sendEvent(

src/plus/integrations/integrationService.ts

@@ -225,7 +225,11 @@ export class IntegrationService implements Disposable {
 			for (const integrationId of integrationIds) {
 				const cloudIntegrationType = toCloudIntegrationType[integrationId];
 				if (cloudIntegrationType == null) {
-					Logger.error(`Attempting to connect unsupported cloud integration type: ${integrationId}`);
+					Logger.error(
+						undefined,
+						scope,
+						`Attempting to connect unsupported cloud integration type: ${integrationId}`,
+					);
 				} else {
 					cloudIntegrationTypes.push(cloudIntegrationType);
 				}

src/system/logger.ts

@@ -326,7 +326,7 @@ export const defaultLogProvider: LogProvider = {
 	log: (logLevel: LogLevel, scope: LogScope | undefined, message: string, ...params: any[]) => {
 		switch (logLevel) {
 			case 'error':
-				Logger.error('', scope, message, ...params);
+				Logger.error(undefined, scope, message, ...params);
 				break;
 			case 'warn':
 				Logger.warn(scope, message, ...params);