Removes I from interface naming of "things"

Author: eamodio

src/annotations/blameAnnotationProvider.ts

@@ -2,20 +2,20 @@
 import { Iterables } from '../system';
 import { ExtensionContext, Range, TextEditor, TextEditorDecorationType } from 'vscode';
 import { AnnotationProviderBase } from './annotationProvider';
-import { GitService, GitUri, IGitBlame } from '../gitService';
+import { GitBlame, GitService, GitUri } from '../gitService';
 import { WhitespaceController } from './whitespaceController';
 
 export abstract class BlameAnnotationProviderBase extends AnnotationProviderBase {
 
-    protected _blame: Promise<IGitBlame>;
+    protected _blame: Promise<GitBlame>;
 
     constructor(context: ExtensionContext, editor: TextEditor, decoration: TextEditorDecorationType, highlightDecoration: TextEditorDecorationType | undefined, whitespaceController: WhitespaceController | undefined, protected git: GitService, protected uri: GitUri) {
         super(context, editor, decoration, highlightDecoration, whitespaceController);
 
         this._blame = this.git.getBlameForFile(this.uri);
     }
 
-    async selection(shaOrLine?: string | number, blame?: IGitBlame) {
+    async selection(shaOrLine?: string | number, blame?: GitBlame) {
         if (!this.highlightDecoration) return;
 
         if (blame === undefined) {
@@ -57,14 +57,14 @@ export abstract class BlameAnnotationProviderBase extends AnnotationProviderBase
         return blame !== undefined && blame.lines.length !== 0;
     }
 
-    protected async getBlame(requiresWhitespaceHack: boolean): Promise<IGitBlame | undefined> {
+    protected async getBlame(requiresWhitespaceHack: boolean): Promise<GitBlame | undefined> {
         let whitespacePromise: Promise<void> | undefined;
         // HACK: Until https://github.com/Microsoft/vscode/issues/11485 is fixed -- override whitespace (turn off)
         if (requiresWhitespaceHack) {
             whitespacePromise = this.whitespaceController && this.whitespaceController.override();
         }
 
-        let blame: IGitBlame;
+        let blame: GitBlame;
         if (whitespacePromise) {
             [blame] = await Promise.all([this._blame, whitespacePromise]);
         }

src/commands/showQuickBranchHistory.ts

@@ -1,15 +1,15 @@
 'use strict';
 import { commands, TextEditor, Uri, window } from 'vscode';
 import { ActiveEditorCachedCommand, Commands, getCommandUri } from './common';
-import { GitService, GitUri, IGitLog } from '../gitService';
+import { GitLog, GitService, GitUri } from '../gitService';
 import { Logger } from '../logger';
 import { Messages } from '../messages';
 import { BranchesQuickPick, BranchHistoryQuickPick, CommandQuickPickItem } from '../quickPicks';
 import { ShowQuickCommitDetailsCommandArgs } from './showQuickCommitDetails';
 
 export interface ShowQuickBranchHistoryCommandArgs {
     branch?: string;
-    log?: IGitLog;
+    log?: GitLog;
     maxCount?: number;
 
     goBackCommand?: CommandQuickPickItem;

src/commands/showQuickCommitDetails.ts

@@ -1,7 +1,7 @@
 'use strict';
 import { commands, TextEditor, Uri, window } from 'vscode';
 import { ActiveEditorCachedCommand, Commands, getCommandUri } from './common';
-import { GitCommit, GitLogCommit, GitService, GitUri, IGitLog } from '../gitService';
+import { GitCommit, GitLog, GitLogCommit, GitService, GitUri } from '../gitService';
 import { Logger } from '../logger';
 import { CommandQuickPickItem, CommitDetailsQuickPick, CommitWithFileStatusQuickPickItem } from '../quickPicks';
 import { ShowQuickCommitFileDetailsCommandArgs } from './showQuickCommitFileDetails';
@@ -11,7 +11,7 @@ import * as path from 'path';
 export interface ShowQuickCommitDetailsCommandArgs {
     sha?: string;
     commit?: GitCommit | GitLogCommit;
-    repoLog?: IGitLog;
+    repoLog?: GitLog;
 
     goBackCommand?: CommandQuickPickItem;
 }

src/commands/showQuickCommitFileDetails.ts

@@ -1,7 +1,7 @@
 'use strict';
 import { TextEditor, Uri, window } from 'vscode';
 import { ActiveEditorCachedCommand, Commands, getCommandUri } from './common';
-import { GitCommit, GitLogCommit, GitService, GitUri, IGitLog } from '../gitService';
+import { GitCommit, GitLog, GitLogCommit, GitService, GitUri } from '../gitService';
 import { Logger } from '../logger';
 import { CommandQuickPickItem, CommitFileDetailsQuickPick } from '../quickPicks';
 import { ShowQuickCommitDetailsCommandArgs } from './showQuickCommitDetails';
@@ -11,7 +11,7 @@ import * as path from 'path';
 export interface ShowQuickCommitFileDetailsCommandArgs {
     sha?: string;
     commit?: GitCommit | GitLogCommit;
-    fileLog?: IGitLog;
+    fileLog?: GitLog;
 
     goBackCommand?: CommandQuickPickItem;
 }

src/commands/showQuickFileHistory.ts

@@ -1,15 +1,15 @@
 'use strict';
 import { commands, Range, TextEditor, Uri, window } from 'vscode';
 import { ActiveEditorCachedCommand, Commands, getCommandUri } from './common';
-import { GitService, GitUri, IGitLog } from '../gitService';
+import { GitLog, GitService, GitUri } from '../gitService';
 import { Logger } from '../logger';
 import { CommandQuickPickItem, FileHistoryQuickPick } from '../quickPicks';
 import { ShowQuickCommitFileDetailsCommandArgs } from './showQuickCommitFileDetails';
 import { Messages } from '../messages';
 import * as path from 'path';
 
 export interface ShowQuickFileHistoryCommandArgs {
-    log?: IGitLog;
+    log?: GitLog;
     maxCount?: number;
     range?: Range;
 

src/currentLineController.ts

@@ -7,7 +7,7 @@ import { Commands } from './commands';
 import { TextEditorComparer } from './comparers';
 import { FileAnnotationType, IConfig, LineAnnotationType, StatusBarCommand } from './configuration';
 import { DocumentSchemes, ExtensionKey } from './constants';
-import { BlameabilityChangeEvent, CommitFormatter, GitCommit, GitContextTracker, GitService, GitUri, IGitCommitLine } from './gitService';
+import { BlameabilityChangeEvent, CommitFormatter, GitCommit, GitCommitLine, GitContextTracker, GitService, GitUri } from './gitService';
 
 const annotationDecoration: TextEditorDecorationType = window.createTextEditorDecorationType({
     after: {
@@ -181,7 +181,7 @@ export class CurrentLineController extends Disposable {
         line = line - this._uri.offset;
 
         let commit: GitCommit | undefined = undefined;
-        let commitLine: IGitCommitLine | undefined = undefined;
+        let commitLine: GitCommitLine | undefined = undefined;
         // Since blame information isn't valid when there are unsaved changes -- don't show any status
         if (this._blameable && line >= 0) {
             const blameLine = await this.git.getBlameForLine(this._uri, line);
@@ -215,7 +215,7 @@ export class CurrentLineController extends Disposable {
         editor.setDecorations(annotationDecoration, []);
     }
 
-    async show(commit: GitCommit, blameLine: IGitCommitLine, editor: TextEditor, line: number) {
+    async show(commit: GitCommit, blameLine: GitCommitLine, editor: TextEditor, line: number) {
         // I have no idea why I need this protection -- but it happens
         if (editor.document === undefined) return;
 
@@ -247,7 +247,7 @@ export class CurrentLineController extends Disposable {
         await this._updateBlame(editor.selection.active.line, editor);
     }
 
-    private async _updateAnnotations(commit: GitCommit, blameLine: IGitCommitLine, editor: TextEditor, line?: number) {
+    private async _updateAnnotations(commit: GitCommit, blameLine: GitCommitLine, editor: TextEditor, line?: number) {
         const cfg = this._config.blame.line;
         if (!cfg.enabled) return;
 

src/git/formatters/commit.ts

@@ -1,7 +1,7 @@
 'use strict';
 import { Strings } from '../../system';
 import { GitCommit } from '../models/commit';
-import { IGitDiffLine } from '../models/diff';
+import { GitDiffLine } from '../models/diff';
 import * as moment from 'moment';
 
 export interface ICommitFormatOptions {
@@ -142,7 +142,7 @@ export class CommitFormatter {
         return `\`${commit.shortSha}\`   __${commit.author}__, ${moment(commit.date).fromNow()}   _(${moment(commit.date).format(dateFormat)})_${message}`;
     }
 
-    static toHoverDiff(commit: GitCommit, previous: IGitDiffLine | undefined, current: IGitDiffLine | undefined): string | undefined {
+    static toHoverDiff(commit: GitCommit, previous: GitDiffLine | undefined, current: GitDiffLine | undefined): string | undefined {
         if (previous === undefined && current === undefined) return undefined;
 
         const codeDiff = this._getCodeDiff(previous, current);
@@ -151,7 +151,7 @@ export class CommitFormatter {
             : `\`Changes\`   \u2014   \`${commit.previousShortSha}\` \u2194 \`${commit.shortSha}\`\n${codeDiff}`;
     }
 
-    private static _getCodeDiff(previous: IGitDiffLine | undefined, current: IGitDiffLine | undefined): string {
+    private static _getCodeDiff(previous: GitDiffLine | undefined, current: GitDiffLine | undefined): string {
         return `\`\`\`
 -  ${previous === undefined ? '' : previous.line.trim()}
 +  ${current === undefined ? '' : current.line.trim()}

src/git/models/blame.ts

@@ -1,25 +1,25 @@
 'use strict';
-import { GitCommit, IGitAuthor, IGitCommitLine } from './commit';
+import { GitAuthor, GitCommit, GitCommitLine } from './commit';
 
-export interface IGitBlame {
+export interface GitBlame {
     repoPath: string;
-    authors: Map<string, IGitAuthor>;
+    authors: Map<string, GitAuthor>;
     commits: Map<string, GitCommit>;
-    lines: IGitCommitLine[];
+    lines: GitCommitLine[];
 }
 
-export interface IGitBlameLine {
-    author: IGitAuthor;
+export interface GitBlameLine {
+    author: GitAuthor;
     commit: GitCommit;
-    line: IGitCommitLine;
+    line: GitCommitLine;
 }
 
-export interface IGitBlameLines extends IGitBlame {
-    allLines: IGitCommitLine[];
+export interface GitBlameLines extends GitBlame {
+    allLines: GitCommitLine[];
 }
 
-export interface IGitBlameCommitLines {
-    author: IGitAuthor;
+export interface GitBlameCommitLines {
+    author: GitAuthor;
     commit: GitCommit;
-    lines: IGitCommitLine[];
+    lines: GitCommitLine[];
 }

src/git/models/commit.ts

@@ -3,30 +3,12 @@ import { Uri } from 'vscode';
 import { Git } from '../git';
 import * as path from 'path';
 
-export interface IGitAuthor {
+export interface GitAuthor {
     name: string;
     lineCount: number;
 }
 
-export interface IGitCommit {
-    type: GitCommitType;
-    repoPath: string;
-    sha: string;
-    fileName: string;
-    author?: string;
-    date: Date;
-    message: string;
-    lines: IGitCommitLine[];
-    originalFileName?: string;
-    previousSha?: string;
-    previousFileName?: string;
-
-    readonly isUncommitted: boolean;
-    previousUri: Uri;
-    uri: Uri;
-}
-
-export interface IGitCommitLine {
+export interface GitCommitLine {
     sha: string;
     previousSha?: string;
     line: number;
@@ -36,10 +18,10 @@ export interface IGitCommitLine {
 
 export type GitCommitType = 'blame' | 'branch' | 'file'  | 'stash';
 
-export class GitCommit implements IGitCommit {
+export class GitCommit {
 
     type: GitCommitType;
-    lines: IGitCommitLine[];
+    lines: GitCommitLine[];
     originalFileName?: string;
     previousSha?: string;
     previousFileName?: string;
@@ -54,7 +36,7 @@ export class GitCommit implements IGitCommit {
         public author: string,
         public date: Date,
         public message: string,
-        lines?: IGitCommitLine[],
+        lines?: GitCommitLine[],
         originalFileName?: string,
         previousSha?: string,
         previousFileName?: string

src/git/models/diff.ts

@@ -1,24 +1,24 @@
 'use strict';
 
-export interface IGitDiffLine {
+export interface GitDiffLine {
     line: string;
     state: 'added' | 'removed' | 'unchanged';
 }
 
-export interface IGitDiffChunk {
-    current: (IGitDiffLine | undefined)[];
+export interface GitDiffChunk {
+    current: (GitDiffLine | undefined)[];
     currentStart: number;
     currentEnd: number;
 
-    previous: (IGitDiffLine | undefined)[];
+    previous: (GitDiffLine | undefined)[];
     previousStart: number;
     previousEnd: number;
 
     chunk?: string;
 }
 
-export interface IGitDiff {
-    chunks: IGitDiffChunk[];
+export interface GitDiff {
+    chunks: GitDiffChunk[];
 
     diff?: string;
 }