Skip to content

Commit f4f267a

Browse files
Updates provider library and adds mergeable state values/permissions fix
1 parent ed3de96 commit f4f267a

File tree

5 files changed

+29
-17
lines changed

5 files changed

+29
-17
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20117,7 +20117,7 @@
2011720117
},
2011820118
"dependencies": {
2011920119
"@gitkraken/gitkraken-components": "10.7.0",
20120-
"@gitkraken/provider-apis": "0.26.1",
20120+
"@gitkraken/provider-apis": "0.26.2",
2012120121
"@gitkraken/shared-web-components": "0.1.1-rc.15",
2012220122
"@gk-nzaytsev/fast-string-truncated-width": "1.1.0",
2012320123
"@lit-labs/signals": "0.1.1",

pnpm-lock.yaml

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/git/models/pullRequest.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,8 @@ export const enum PullRequestMergeableState {
120120
Unknown = 'Unknown',
121121
Mergeable = 'Mergeable',
122122
Conflicting = 'Conflicting',
123+
FailingChecks = 'FailingChecks',
124+
BlockedByPolicy = 'BlockedByPolicy',
123125
}
124126

125127
export const enum PullRequestStatusCheckRollupState {

src/plus/integrations/providers/github/models.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -296,6 +296,10 @@ export function toGitHubPullRequestMergeableState(
296296
return 'MERGEABLE';
297297
case PullRequestMergeableState.Conflicting:
298298
return 'CONFLICTING';
299+
case PullRequestMergeableState.FailingChecks:
300+
return 'UNKNOWN';
301+
case PullRequestMergeableState.BlockedByPolicy:
302+
return 'UNKNOWN';
299303
case PullRequestMergeableState.Unknown:
300304
return 'UNKNOWN';
301305
}

src/plus/integrations/providers/models.ts

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -701,14 +701,17 @@ export const toProviderPullRequestMergeableState = {
701701
[PullRequestMergeableState.Mergeable]: GitPullRequestMergeableState.Mergeable,
702702
[PullRequestMergeableState.Conflicting]: GitPullRequestMergeableState.Conflicts,
703703
[PullRequestMergeableState.Unknown]: GitPullRequestMergeableState.Unknown,
704+
[PullRequestMergeableState.FailingChecks]: GitPullRequestMergeableState.FailingChecks,
705+
[PullRequestMergeableState.BlockedByPolicy]: GitPullRequestMergeableState.Blocked,
704706
};
705707

706708
export const fromProviderPullRequestMergeableState = {
707709
[GitPullRequestMergeableState.Mergeable]: PullRequestMergeableState.Mergeable,
708710
[GitPullRequestMergeableState.Conflicts]: PullRequestMergeableState.Conflicting,
711+
[GitPullRequestMergeableState.Blocked]: PullRequestMergeableState.BlockedByPolicy,
712+
[GitPullRequestMergeableState.FailingChecks]: PullRequestMergeableState.FailingChecks,
709713
[GitPullRequestMergeableState.Unknown]: PullRequestMergeableState.Unknown,
710714
[GitPullRequestMergeableState.Behind]: PullRequestMergeableState.Unknown,
711-
[GitPullRequestMergeableState.Blocked]: PullRequestMergeableState.Unknown,
712715
[GitPullRequestMergeableState.UnknownAndBlocked]: PullRequestMergeableState.Unknown,
713716
[GitPullRequestMergeableState.Unstable]: PullRequestMergeableState.Unknown,
714717
};
@@ -870,16 +873,19 @@ export function toProviderPullRequest(pr: PullRequest): ProviderPullRequest {
870873
],
871874
}
872875
: null,
873-
permissions: {
874-
canMerge:
875-
pr.viewerCanUpdate === true &&
876-
pr.repository.accessLevel != null &&
877-
pr.repository.accessLevel >= RepositoryAccessLevel.Write,
878-
canMergeAndBypassProtections:
879-
pr.viewerCanUpdate === true &&
880-
pr.repository.accessLevel != null &&
881-
pr.repository.accessLevel >= RepositoryAccessLevel.Admin,
882-
},
876+
permissions:
877+
pr.viewerCanUpdate == null
878+
? null
879+
: {
880+
canMerge:
881+
pr.viewerCanUpdate === true &&
882+
pr.repository.accessLevel != null &&
883+
pr.repository.accessLevel >= RepositoryAccessLevel.Write,
884+
canMergeAndBypassProtections:
885+
pr.viewerCanUpdate === true &&
886+
pr.repository.accessLevel != null &&
887+
pr.repository.accessLevel >= RepositoryAccessLevel.Admin,
888+
},
883889
mergeableState: pr.mergeableState
884890
? toProviderPullRequestMergeableState[pr.mergeableState]
885891
: GitPullRequestMergeableState.Unknown,

0 commit comments

Comments
 (0)