Skip to content

Commit f8f08ba

Browse files
committed
Keeps strong typing
(though avoids using the enum directly since it will pull in the whole module)
1 parent 970c352 commit f8f08ba

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

src/commands/cloudIntegrations.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import { Command } from './base';
88
export interface ManageCloudIntegrationsCommandArgs extends Source {
99
integrationId?: IssueIntegrationId.Jira;
1010
}
11+
1112
@command()
1213
export class ManageCloudIntegrationsCommand extends Command {
1314
constructor(private readonly container: Container) {

src/webviews/apps/commitDetails/components/gl-commit-details.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,10 @@ import { customElement, property, state } from 'lit/decorators.js';
33
import { unsafeHTML } from 'lit/directives/unsafe-html.js';
44
import { when } from 'lit/directives/when.js';
55
import type { Autolink } from '../../../../annotations/autolinks';
6+
import type { ManageCloudIntegrationsCommandArgs } from '../../../../commands/cloudIntegrations';
67
import type { IssueOrPullRequest } from '../../../../git/models/issue';
78
import type { PullRequestShape } from '../../../../git/models/pullRequest';
9+
import type { IssueIntegrationId } from '../../../../plus/integrations/providers/models';
810
import type { Serialized } from '../../../../system/serialize';
911
import type { State } from '../../../commitDetails/protocol';
1012
import { messageHeadlineSplitterToken } from '../../../commitDetails/protocol';
@@ -171,13 +173,13 @@ export class GlCommitDetails extends GlDetailsBase {
171173
let message = html`<a
172174
href="command:gitlens.plus.cloudIntegrations.manage?${encodeURIComponent(
173175
JSON.stringify({
174-
integrationId: 'jira',
176+
integrationId: 'jira' as IssueIntegrationId.Jira,
175177
source: 'inspect',
176178
detail: {
177179
action: 'connect',
178180
integration: 'jira',
179181
},
180-
}),
182+
} satisfies ManageCloudIntegrationsCommandArgs),
181183
)}"
182184
>Connect to Jira Cloud</a
183185
>
@@ -243,13 +245,13 @@ export class GlCommitDetails extends GlDetailsBase {
243245
const { hasAccount, hasConnectedJira } = this.state ?? {};
244246
const jiraIntegrationLink = `command:gitlens.plus.cloudIntegrations.manage?${encodeURIComponent(
245247
JSON.stringify({
246-
integrationId: 'jira',
248+
integrationId: 'jira' as IssueIntegrationId.Jira,
247249
source: 'inspect',
248250
detail: {
249251
action: 'connect',
250252
integration: 'jira',
251253
},
252-
}),
254+
} satisfies ManageCloudIntegrationsCommandArgs),
253255
)}`;
254256

255257
return html`

src/webviews/apps/settings/settings.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
/*global document IntersectionObserver*/
22
import './settings.scss';
3+
import type { ManageCloudIntegrationsCommandArgs } from '../../../commands/cloudIntegrations';
34
import type { AutolinkReference } from '../../../config';
5+
import type { IssueIntegrationId } from '../../../plus/integrations/providers/models';
46
import type { IpcMessage, UpdateConfigurationParams } from '../../protocol';
57
import { DidChangeConfigurationNotification, UpdateConfigurationCommand } from '../../protocol';
68
import type { State } from '../../settings/protocol';
@@ -804,13 +806,13 @@ export class SettingsApp extends App<State> {
804806
const { hasAccount, hasConnectedJira } = this.state;
805807
let message = `<a href="command:gitlens.plus.cloudIntegrations.manage?${encodeURIComponent(
806808
JSON.stringify({
807-
integrationId: 'jira',
809+
integrationId: 'jira' as IssueIntegrationId.Jira,
808810
source: 'settings',
809811
detail: {
810812
action: 'connect',
811813
integration: 'jira',
812814
},
813-
}),
815+
} satisfies ManageCloudIntegrationsCommandArgs),
814816
)}">Connect to Jira Cloud</a> &mdash; ${
815817
hasAccount ? '' : 'sign up and '
816818
}get access to automatic rich Jira autolinks.`;

0 commit comments

Comments
 (0)