Fixes relative date formatting threshold

Author: eamodio

src/env/node/gk/localSharedGkStorageLocationProvider.ts

@@ -78,7 +78,7 @@ export class LocalSharedGkStorageLocationProvider implements SharedGkStorageLoca
 				break;
 			}
 
-			const currentTime = new Date().getTime();
+			const currentTime = Date.now();
 			if (currentTime - stat.ctime > 30000) {
 				// File exists, but the timestamp is older than 30 seconds, so we can safely remove it
 				break;

src/features.ts

@@ -160,7 +160,7 @@ export function getFeaturePreviewStatus(preview: FeaturePreview): FeaturePreview
 	const usages = preview?.usages;
 	if (!usages?.length) return 'eligible';
 
-	const remainingHours = (new Date(usages[usages.length - 1].expiresOn).getTime() - new Date().getTime()) / hoursInMs;
+	const remainingHours = (new Date(usages[usages.length - 1].expiresOn).getTime() - Date.now()) / hoursInMs;
 
 	if (
 		usages.length <= proFeaturePreviewUsages &&

src/system/date.ts

@@ -79,7 +79,7 @@ export function createFromDateDelta(
 }
 
 export function fromNow(date: Date | number, short?: boolean): string {
-	const elapsed = (typeof date === 'number' ? date : date.getTime()) - new Date().getTime();
+	const elapsed = (typeof date === 'number' ? date : date.getTime()) - Date.now();
 
 	for (const [unit, threshold, divisor, shortUnit] of relativeUnitThresholds) {
 		const elapsedABS = Math.abs(elapsed);
@@ -101,7 +101,7 @@ export function fromNow(date: Date | number, short?: boolean): string {
 				}
 
 				if (locale === 'en' || locale?.startsWith('en-')) {
-					const value = Math.round(elapsedABS / divisor);
+					const value = Math.floor(elapsedABS / divisor);
 					return `${value}${shortUnit}`;
 				}
 
@@ -113,7 +113,7 @@ export function fromNow(date: Date | number, short?: boolean): string {
 					});
 				}
 
-				return defaultShortRelativeTimeFormat.format(Math.round(elapsed / divisor), unit);
+				return defaultShortRelativeTimeFormat.format(Math.trunc(elapsed / divisor), unit);
 			}
 
 			if (defaultRelativeTimeFormat == null) {
@@ -123,7 +123,7 @@ export function fromNow(date: Date | number, short?: boolean): string {
 					style: 'long',
 				});
 			}
-			return defaultRelativeTimeFormat.format(Math.round(elapsed / divisor), unit);
+			return defaultRelativeTimeFormat.format(Math.trunc(elapsed / divisor), unit);
 		}
 	}
 

src/webviews/plus/timeline/timelineWebview.ts

@@ -1138,7 +1138,7 @@ function generateRandomTimelineDataset(itemType: TimelineScopeType): TimelineDat
 	const count = 10;
 	for (let i = 0; i < count; i++) {
 		// Generate a random date between now and 3 months ago
-		const date = new Date(new Date().getTime() - Math.floor(Math.random() * (3 * 30 * 24 * 60 * 60 * 1000)));
+		const date = new Date(Date.now() - Math.floor(Math.random() * (3 * 30 * 24 * 60 * 60 * 1000)));
 		const author = authors[Math.floor(Math.random() * authors.length)];
 
 		// Generate random additions/deletions between 1 and 20, but ensure we have a tiny and large commit