Error "Cannot read properties of null (reading 'map')

[juanmiromero]

Description

Logging in with the graph view opened shows the message "Cannot read properties of null (reading 'map')." I was not logged in, and my 3-day trial expired. When I logged in to my account, everything seemed to work fine, but the error message was shown.

GitLens Version

v2024.4.2405 (pre-release)

VS Code Version

Version: 1.88.1 (Universal)
Commit: e170252f762678dec6ca2cc69aba1570769a5d39
Date: 2024-04-10T17:42:52.765Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Darwin arm64 22.5.0

Git Version

git version 2.39.2 (Apple Git-143)

Logs, Screenshots, Screen Captures, etc

3-GitLens.log
6-GitLens (Git).log

[eamodio]

@axosoft-ramint Here is an excerpt from the log:

[2024-04-25 12:25:55.913] [  5dc] WorkspacesService.getWorkspaces
[2024-04-25 12:25:55.914] [  5dd] SubscriptionService.ensureSession(e=false)
[2024-04-25 12:25:55.914] [  5dd] SubscriptionService.ensureSession(e=false) completed [0ms]
[2024-04-25 12:25:55.929] [   35] WebviewView(gitlens.views.home) Resolving view
[2024-04-25 12:25:55.931] [   35] WebviewView(gitlens.views.home) Showing view
[2024-04-25 12:25:55.931] [  5de] WebviewController(gitlens.views.home).show
[2024-04-25 12:25:55.931] [  5df] GitProviderService.hasUnsafeRepositories
[2024-04-25 12:25:55.931] [  5df] GitProviderService.hasUnsafeRepositories returned false [0ms]
[2024-04-25 12:25:55.932] [  5e0] SubscriptionService.ensureSession(e=false)
[2024-04-25 12:25:55.932] [  5e0] SubscriptionService.ensureSession(e=false) completed [0ms]
[2024-04-25 12:25:55.932] [   37] WebviewView(gitlens.views.account) Resolving view
[2024-04-25 12:25:55.933] [   37] WebviewView(gitlens.views.account) Showing view
[2024-04-25 12:25:55.933] [  5e2] WebviewController(gitlens.views.account).show
[2024-04-25 12:25:55.933] [  5e3] SubscriptionService.ensureSession(e=false)
[2024-04-25 12:25:55.933] [  5e3] SubscriptionService.ensureSession(e=false) completed [0ms]
[2024-04-25 12:25:55.933] [  5e4] SubscriptionService.ensureSession(e=false)
[2024-04-25 12:25:55.933] [  5e4] SubscriptionService.ensureSession(e=false) completed [0ms]
[2024-04-25 12:25:55.933] [  5dc] WorkspacesService.getWorkspaces — failed [19ms]
TypeError: Cannot read properties of null (reading 'map')

My guess is that we failed to parse the local workspace file correctly (maybe caused by a GKC issue?). We probably just need more robust handling.

[axosoft-ramint]

@juanmiromero Would you mind sending me the contents of your localWorkspaces.json file in your {user}/.gk folder?

[axosoft-ramint]

I was able to repro this by setting the repositories property to null or just not having it be there on a local workspace. This should not theoretically be possible but likely is happening as a result of some changes on GKD side. Pushed a fix which should be available to test in the next pre-release.

[axosoft-ramint]

Fixed in commit: 765c42f

[axosoft-ramint]

@juanmiromero Please check on the latest pre-release when you get the chance and let us know if the error is gone or not. Thanks!