Yet another "Element with id is already registered"

[DavideCanton]

Description

In a simple repository, right clicking on a branch and choosing "Compare with HEAD", an error notification appears with the message

Element with id gitlens://viewnode/results-commits/branch-status-direction/behind/comparison/HEAD+master+16 is already registered

Refreshing the compare does not fix it, swapping the branches using the double arrow does.
Also it's not always reproducible, it seems kinda random.

GitLens Version

15.0.4

VS Code Version

Version: 1.90.0 (system setup)
Commit: 89de5a8d4d6205e5b11647eb6a74844ca23d2573
Date: 2024-06-04T19:33:54.889Z
Electron: 29.4.0
ElectronBuildId: 9593362
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Windows_NT x64 10.0.19043

Git Version

git version 2.42.0.windows.2

Logs, Screenshots, Screen Captures, etc

In the last rows of the debug log, there were these rows:

[2024-06-07 00:49:40.436] [  9a5] CompareResultsNode(gitlens://viewnode/compare-results/comparison/HEAD+master+16).ensureSubscription
[2024-06-07 00:49:40.436] [  9a5] CompareResultsNode(gitlens://viewnode/compare-results/comparison/HEAD+master+16).ensureSubscription completed [0ms]
[2024-06-07 00:49:40.436] [  9a6] CompareResultsNode(gitlens://viewnode/compare-results/comparison/HEAD+master+16).ensureSubscription
[2024-06-07 00:49:40.437] [  9a6] CompareResultsNode(gitlens://viewnode/compare-results/comparison/HEAD+master+16).ensureSubscription completed [0ms]

I suspect that for some reason some code runs twice and tries to register the same element twice.

Here there is a gif reproducing the issue:

[jkelroy]

This seems to only happen when right-clicking a branch in the branch sidebar - I do not see this behavior when using Compare with HEAD from the commit graph.

I can consistently reproduce this when using Compare with HEAD twice. i.e.

• Have GitLens repo open
• Switch to feature/GLVSC-504-lp-link-to-gkdev
• Right-click main > Compare with HEAD - repeat

[ohliumliu]

My observation is this

• Starting with no prior history in "History & Compare"
• Compare an old commit with head by right click the old commit and select compare with head -> History & Compare doesn't show the result under "Comparing HEAD with commit-hash".
• Click the button "Open All Changes" can show the changes in the editor.
• Do this -- "Compare an old commit with head by right click the old commit and select compare with head" -- for a second time -> History & Compare show results for both comparison.

[liaoyann]

I also has the same problem. It become ok when i restart vscode。

[EddyDonorLink]

why this bug tag removed @d13 ?

still have the same issue

[eamodio]

Fixed by 3115830 and 7b29bef