-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Open
Open
Consider removing inheritance of AccountAuthenticationProvider from vscode's AuthenticationProvider#3574
Enhancement
Copy link
Labels
triageNeeds to be looked atNeeds to be looked at
Description
AccountAuthenticationProvider has had inheritance from AuthenticationProvider of VSCode for being registered in VSCode as an account provider.
In #3524 we have stopped registering our provider in VSCode, so technically we the inheritance is not necessary anymore. So we can consider removal, but also we might decide to leave it as is.
I suppose the decision depends on the following:
- On the one hand, AccountAuthenticationProvider in its current state may contain methods that are implemented only to satisfy inheritance of AuthenticationProvider but are not actually in use anymore.
- On the other hand, the parent class can contain some methods that are in use and that will need to be re-implemented.
Therefore we need to weigh whether it's worth or not to remove the inheritance and implement. We can make the decision by:
- just starting the replacement and seeing how it goes
- analising the current code
- however, maybe Eric or Keith or Ramin can say it immediately without even touching the code
So, if we decide to rid of the inheritance it should be done in this ticket. If we decide to leave the inheritance, this ticket can be just closed as "won't do"
Metadata
Metadata
Assignees
Labels
triageNeeds to be looked atNeeds to be looked at