3529 Change tag terminal-run commands into normal commands w/ proper error handling
#3670
+170
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
axosoft-ramint
left a comment
axosoft-ramint
left a comment
There was a problem hiding this comment.
A couple of thoughts I wanted to get your input on before testing
sergiolms
force-pushed
the
feature/#3529_change_tag_terminal-run_cmds_into_normal_cmds
branch
from
4c79fc8 to
514f618
Compare
axosoft-ramint
requested changes
Oct 22, 2024
Contributor
axosoft-ramint
left a comment
axosoft-ramint
left a comment
There was a problem hiding this comment.
Build errors:
I think most of them are solvable by setting up a type on tagErrorAndReason: const tagErrorAndReason: [RegExp, TagErrorReason][] = ...
Not sure on that last one though.
Contributor
Author
Yup... That was mostly it. I'm not sure why it didn't pop up before. 🤷♂️ Thank you |
sergiolms
force-pushed
the
feature/#3529_change_tag_terminal-run_cmds_into_normal_cmds
branch
from
59925a0 to
3597a47
Compare
sergiolms
force-pushed
the
feature/#3529_change_tag_terminal-run_cmds_into_normal_cmds
branch
from
3597a47 to
4afddec
Compare
axosoft-ramint
approved these changes
Oct 24, 2024
Contributor
axosoft-ramint
left a comment
axosoft-ramint
left a comment
There was a problem hiding this comment.
Tested creating and deleting a tag and it LGTM. Let me know if you want me to test other cases.
sergiolms
force-pushed
the
feature/#3529_change_tag_terminal-run_cmds_into_normal_cmds
branch
from
4afddec to
e7aab45
Compare
axosoft-ramint
deleted the
feature/#3529_change_tag_terminal-run_cmds_into_normal_cmds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3529
Here's what an error looks like now:
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses