Skip to content

Conversation

eatmorespinach
Copy link
Contributor

Update top section before Discover Powerful Features section since it's ready now before GL 16.

@justinrobots justinrobots self-requested a review October 23, 2024 19:59
Copy link
Collaborator

@justinrobots justinrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eatmorespinach just one minor comment, but the rest of this looks good to me!

README.md Outdated

- marked with a `Pro` require a [trial or paid plan](https://www.gitkraken.com/gitlens/pricing) for use on privately-hosted repos
- marked with a `Preview` require a GitKraken account, with access level based on your [plan](https://www.gitkraken.com/gitlens/pricing), e.g. Free, Pro, etc
You can try GitLens Pro for free. When you're ready to upgrade, a GitKraken [paid plan](https://www.gitkraken.com/gitlens/pricing) is required for privately-hosted repos. Some Pro features are available for free on public repos. `Preview` features may require a GitKraken account and could become Pro features in the future.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eatmorespinach did we determine if there was a good URL for making "try GitLens Pro for free" a link to start a sign-in and start a trial that would still be attributable GitLens? Seems like this would be a more worthwhile link than "paid plan" that shows the pricing page.

Copy link
Contributor Author

@eatmorespinach eatmorespinach Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinrobots Yep added the GL GK.dev signup link. I was debating whether or not to leave the pricing pg link and that sentence, and went ahead and removed. If there's feedback/thoughts that it should be displayed we can add back in. Go ahead and make any final edits/tweaks here to your discretion as well @justinrobots - I'm good with that.

I just added this commit here in github - Lmk if you don't see it - will let you take it from here.

Removed the pricing pg link, and added link to signup for GL Pro
Copy link
Collaborator

@justinrobots justinrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me. Anything you would add or change @eamodio ?

@justinrobots justinrobots merged commit 4d65101 into gitkraken:main Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants