Reset cache every 24 hours. Reset session correctly

Author: dzaporozhets

app/controllers/application_controller.rb

@@ -2,6 +2,7 @@ class ApplicationController < ActionController::Base
   protect_from_forgery
 
   helper_method :current_user
+  before_filter :reset_cache
 
   private
 
@@ -14,7 +15,7 @@ def sign_in(user)
   end
 
   def sign_out
-    @current_user = session[:current_user] = nil
+    reset_session
   end
 
   def authenticate_user!
@@ -39,4 +40,11 @@ def authorize_access_project!
   def page_404
     render file: "#{Rails.root}/public/404.html", status: 404, layout: false
   end
+
+  # Reset user cache every day for security purposes
+  def reset_cache
+    if current_user && current_user.sync_at < (Time.zone.now - 24.hours)
+      current_user.reset_cache
+    end
+  end
 end

app/models/user.rb

@@ -37,14 +37,8 @@ def can_access_project?(project_gitlab_id)
       private_token: self.private_token,
     }
 
-    #Rails.cache.fetch(cache_key(project_gitlab_id, (Time.zone.now.to_i.round(-2)))) do
-      #Network.new.project(self.url, opts, project_gitlab_id)
-    #end
-
-    authorized_projects[project_gitlab_id] ||= !!Network.new.project(self.url, opts, project_gitlab_id)
-  end
-
-  def authorized_projects
-    @authorized_projects ||= {}
+    Rails.cache.fetch(cache_key(project_gitlab_id, sync_at)) do
+      !!Network.new.project(self.url, opts, project_gitlab_id)
+    end
   end
 end