Skip to content

Commit 18c7d52

Browse files
balasankarcAlexand
andcommitted
Merge branch 'add-reviewer-roulette' into 'master'
Enable roulette and adjust review comment See merge request https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/7203 Merged-by: Balasankar 'Balu' C <[email protected]> Approved-by: Jason Plum <[email protected]> Approved-by: Dustin Collins <[email protected]> Approved-by: Balasankar 'Balu' C <[email protected]> Co-authored-by: João Cunha <[email protected]>
2 parents 42f6a51 + bc42169 commit 18c7d52

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

Dangerfile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22

33
require 'gitlab-dangerfiles'
44

5-
Gitlab::Dangerfiles.for_project(self) do |gitlab_dangerfiles|
5+
# Documentation reference: https://gitlab.com/gitlab-org/ruby/gems/gitlab-dangerfiles
6+
Gitlab::Dangerfiles.for_project(self, 'omnibus-gitlab') do |gitlab_dangerfiles|
67
gitlab_dangerfiles.import_plugins
78

8-
gitlab_dangerfiles.import_dangerfiles(except: %w[simple_roulette])
9+
gitlab_dangerfiles.import_dangerfiles
910
end

danger/reviewers/Dangerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
return if helper.has_scoped_label_with_scope?("workflow")
44

55
REVIEWERS_MESSAGE = <<~MSG
6-
Please add the ~"workflow::ready for review" label once you think the MR is ready to for an initial review.
6+
Once your MR is ready for review you can comment `@gitlab-bot ready <@user>` to request the first review to someone. It's recommended that you pick the one suggested by the reviewer roulette. But you can ignore it and assign it to someone else if you see fit.
77
8-
Merge requests are handled according to the workflow documented in our [handbook](https://about.gitlab.com/handbook/engineering/development/enablement/systems/distribution/merge_requests.html) and should receive a response within the limit documented in our [First-response SLO](https://about.gitlab.com/handbook/engineering/workflow/code-review/#first-response-slo).
8+
Merge requests are handled according to the workflow documented in our [handbook](https://about.gitlab.com/handbook/engineering/development/enablement/systems/distribution/merge_requests.html#workflow) and should receive a response within the limit documented in our [Service-level objective (SLO)](https://about.gitlab.com/handbook/engineering/development/enablement/systems/distribution/merge_requests.html#service-level-objective).
99
10-
If you don't receive a response, please mention `@gitlab-org\/distribution`, or one of our [Project Maintainers](https://about.gitlab.com/handbook/engineering/projects/#omnibus-gitlab)
10+
If you don't receive a response from the reviewer within the SLO, please mention `@gitlab-org\/distribution`, or one of our [Project Maintainers](https://about.gitlab.com/handbook/engineering/projects/#omnibus-gitlab)
1111
MSG
1212

1313
# Print maintainers message

0 commit comments

Comments
 (0)