Merge branch 'dont-allow-build-package-on-all-os-to-fail' into 'master'

Do not allow build-package-on-all-os job to fail on automatic runs

See merge request https://gitlab.com/gitlab-org/omnibus-gitlab/-/merge_requests/6904

Merged-by: Robert Marshall <[email protected]>
Approved-by: Robert Marshall <[email protected]>
Co-authored-by: Balasankar "Balu" C <[email protected]>

Author: Robert Marshall

gitlab-ci-config/gitlab-com.yml

@@ -768,7 +768,6 @@ build-package-on-all-os:
     # Triggers from GitLab Rails/Gitaly/GitLab Pages pipeline which forced building on all OS automatically
     - if: '$PIPELINE_TYPE =~ /TRIGGERED_(CE|EE)_PIPELINE/ && $BUILD_ON_ALL_OS == "true"'
       when: always
-      allow_failure: true
       variables: !reference [.build-package-on-all-os-vars]
     # MR pipelines from omnibus-gitlab that change files which require building on all OS automatically
     - if: '$PIPELINE_TYPE =~ /TRIGGERED_(CE|EE)_PIPELINE/ && $CI_PIPELINE_SOURCE != "pipeline"'
@@ -778,7 +777,6 @@ build-package-on-all-os:
        - config/software/**
        - config/patches/**
       when: always
-      allow_failure: true
       variables: !reference [.build-package-on-all-os-vars]
     # Covering the remaining scenarios - provide the job to be manually run by developers, if required
     # (i) MR pipelines from omnibus-gitlab that doesn't change files which require building on all OS