You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .gitlab/issue_templates/Security developer workflow.md
+8-4Lines changed: 8 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -9,10 +9,8 @@ Set the title to: `Description of the original issue`
9
9
### Prior to starting the security release work
10
10
11
11
-[ ] Read the [security process for developers] if you are not familiar with it.
12
-
-[ ] Mark this [issue as related] to the Security Release tracking issue. You can find it on the topic of the `#releases` Slack channel.
13
12
- Fill out the [Links section](#links):
14
13
-[ ] Next to **Issue on Omnibus GitLab**, add a link to the `gitlab-org/omnibus-gitlab` issue that describes the security vulnerability.
15
-
-[ ] Next to **Security Release tracking issue**, add a link to the security release issue that will include this security issue.
16
14
17
15
### Development
18
16
@@ -27,12 +25,19 @@ After your merge request has been approved according to our approval guidelines,
27
25
28
26
-[ ] Once the MR is ready to be merged, create MRs targeting the latest 3 stable branches
29
27
* At this point, it might be easy to squash the commits from the MR into one
28
+
* Depending on when development is happening, you may need to wait for the last stable branch to be created. If the ~"security-notifications" label is applied to this issue, you will receive a ping when the branch is created.
30
29
-[ ] Create each MR targeting the stable branch `X-Y-stable`, using the [Security Release merge request template].
31
30
* Every merge request will have its own set of TODOs, so make sure to complete those.
32
31
-[ ] On the "Related merge requests" section, ensure all MRs are linked to this issue.
33
32
* This section should only list the merge requests created for this issue: One targeting `master` and the 3 backports.
34
33
-[ ] If this issue requires less than 4 merge requests, post a message on the Security Release Tracking Issue and ping the Release Managers.
35
34
35
+
#### Assigning to a release
36
+
37
+
-[ ] When this issue is ready for release (all needed backports are approved and ready to be merged), apply the ~"security-target" label for it to be evaluated and linked to the next planned security release tracking issue.
38
+
* The `gitlab-release-tools-bot` evaluates and links issues with the label to the next planned security release tracking issue. If the bot finds the issue is not ready to be included in the security release, it will leave a comment on the issue explaining what needs to be done.
39
+
* This issue will only be included in a security release if it is successfully linked to the security release tracking issue.
40
+
36
41
#### Documentation and final details
37
42
38
43
-[ ] Ensure the [Links section](#links) is completed.
@@ -48,7 +53,6 @@ After your merge request has been approved according to our approval guidelines,
48
53
| Description | Link |
49
54
| -------- | -------- |
50
55
| Issue on [Omnibus GitLab](https://gitlab.com/gitlab-org/omnibus-gitlab/issues)| #TODO |
51
-
| Security Release tracking issue | #TODO |
52
56
53
57
#### Details
54
58
@@ -65,4 +69,4 @@ After your merge request has been approved according to our approval guidelines,
65
69
[issue as related]: https://docs.gitlab.com/ee/user/project/issues/related_issues.html#adding-a-related-issue
0 commit comments