Skip to content

Commit 86c5285

Browse files
committed
Add clean up steps in preparation for re2 v2.0 gem
As mentioned in https://ruby.social/@mudge/111029298058288514, re2 v2.0 will ship with precompiled native gems. In preparation for that, perform clean up on unnecessary files: 1. As we do with nokogiri and gprc, remove unnecessary precompiled libraries for unused Ruby versions. 2. For arm64 platforms where we recompile native gems from source, the `ports` directory holds the abseil-cpp and libre2 tarballs. The extracted source, headers, and compiled libraries are also stored there. These files are not necessary since the final shared library statically links with the libraries. These changes are backwards compatible with re2 v1.0 since v1.0 doesn't ship with these files. Changelog: changed
1 parent c17552f commit 86c5285

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

config/projects/gitlab.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,7 @@
261261
exclude 'embedded/lib/ruby/gems/*/gems/nokogumbo-*/ext'
262262
exclude 'embedded/lib/ruby/gems/*/gems/rbtrace-*/ext/src'
263263
exclude 'embedded/lib/ruby/gems/*/gems/rbtrace-*/ext/dst'
264+
exclude 'embedded/lib/ruby/gems/*/gems/re2-*/ports'
264265
exclude 'embedded/lib/ruby/gems/*/gems/*pg_query-*/ext'
265266

266267
# Exclude exe files from Python libraries

config/software/gitlab-rails.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,8 @@
138138
'google-protobuf' => 'lib/google',
139139
'grpc' => 'src/ruby/lib/grpc',
140140
'prometheus-client-mmap' => 'lib',
141-
'nokogiri' => 'lib'
141+
'nokogiri' => 'lib',
142+
're2' => 'lib'
142143
}
143144

144145
# Delete unused shared libraries included in the gems

0 commit comments

Comments
 (0)