Skip to content

Commit a17b4c8

Browse files
committed
Fix patroni no longer working with update to ydiff 1.3
ydiff 1.3.0 was released on April 2, 2024 (https://pypi.org/project/ydiff/#history), and the patroni install quietly updated to ydiff 1.3.0 from 1.2.0. https://github.com/zalando/patroni/blob/v3.0.1/requirements.txt#L15 allows any version of ydiff above 1.2.0, but as described in https://github.com/zalando/patroni/blob/634b44ee0586f063033074806a42b534a354cbff/docs/releases.rst#L16 ydiff 1.3 requires the cdiff module. To fix this problem, pin the version of ydiff to 1.2.0 until we can upgrade patroni. Changelog: fixed
1 parent 42e34c1 commit a17b4c8

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

config/software/patroni.rb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,13 @@
3535
# https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues/5701
3636
command "#{install_dir}/embedded/bin/pip3 install prettytable==0.7.2", env: env
3737

38+
# Pin ydiff to 1.2 since 1.3 requires cdiff:
39+
# https://github.com/zalando/patroni/blob/634b44ee0586f063033074806a42b534a354cbff/docs/releases.rst
40+
# According to Patroni 3.3.0 release notes, upgrading to this version
41+
# should be enough to fix this problem. We should test unpinning
42+
# this library once we update to Patroni 3.3.0.
43+
# See: https://github.com/zalando/patroni/blob/634b44ee0586f063033074806a42b534a354cbff/docs/releases.rst
44+
command "#{install_dir}/embedded/bin/pip3 install ydiff==1.2", env: env
45+
3846
command "#{install_dir}/embedded/bin/pip3 install patroni[consul]==#{version}", env: env
3947
end

0 commit comments

Comments
 (0)