Split QA related information to own class

Move the following method:
* `Build::Info.qa_image` => `Build::Info::QA.image`

Signed-off-by: Balasankar "Balu" C <[email protected]>

Author: balasankarc

lib/gitlab/build/facts.rb

@@ -75,7 +75,7 @@ def common_vars
       def qa_trigger_vars
         %W[
           QA_RELEASE=#{Build::GitlabImage.gitlab_registry_image_address(tag: Build::Info::Docker.tag)}
-          QA_IMAGE=#{Build::Info.qa_image}
+          QA_IMAGE=#{Build::Info::QA.image}
           QA_TESTS=#{Gitlab::Util.get_env('QA_TESTS')}
           ALLURE_JOB_NAME=#{allure_job_name}-#{Build::Info::Package.edition}
           GITLAB_SEMVER_VERSION=#{Build::Info::Git.latest_stable_tag.tr('+', '-')}

lib/gitlab/build/info.rb

@@ -15,10 +15,6 @@ class Info
     }.freeze
 
     class << self
-      def qa_image
-        Gitlab::Util.get_env('QA_IMAGE') || "#{Gitlab::Util.get_env('CI_REGISTRY')}/#{Build::Info::Components::GitLabRails.project_path}/#{Build::Info::Package.name}-qa:#{Build::Info::Components::GitLabRails.ref(prepend_version: false)}"
-      end
-
       def gcp_release_bucket
         # All tagged builds are pushed to the release bucket
         # whereas regular branch builds use a separate one

lib/gitlab/build/info/qa.rb

@@ -0,0 +1,11 @@
+module Build
+  class Info
+    class QA
+      class << self
+        def image
+          Gitlab::Util.get_env('QA_IMAGE') || "#{Gitlab::Util.get_env('CI_REGISTRY')}/#{Build::Info::Components::GitLabRails.project_path}/#{Build::Info::Package.name}-qa:#{Build::Info::Components::GitLabRails.ref(prepend_version: false)}"
+        end
+      end
+    end
+  end
+end

lib/gitlab/build/qa_image.rb

@@ -1,4 +1,5 @@
 require_relative 'image'
+require_relative 'info/qa'
 require_relative 'gitlab_image'
 require_relative '../skopeo_helper'
 
@@ -15,7 +16,7 @@ def self.gitlab_registry_image_name
     end
 
     def self.copy_image_to_dockerhub(final_tag)
-      source = Build::Info.qa_image
+      source = Build::Info::QA.image
       target = "#{dockerhub_image_name}:#{final_tag}"
 
       SkopeoHelper.login('gitlab-ci-token', Gitlab::Util.get_env('CI_JOB_TOKEN'), Gitlab::Util.get_env('CI_REGISTRY'))

spec/lib/gitlab/build/qa_image_spec.rb

@@ -30,7 +30,7 @@
 
   describe '.copy_image_to_dockerhub' do
     before do
-      allow(Build::Info).to receive(:qa_image).and_return('registry.gitlab.com/gitlab-org/gitlab/gitlab-ce-qa:1234567890')
+      allow(Build::Info::QA).to receive(:image).and_return('registry.gitlab.com/gitlab-org/gitlab/gitlab-ce-qa:1234567890')
 
       allow(SkopeoHelper).to receive(:login).and_return(true)
       allow(SkopeoHelper).to receive(:copy_image).and_return(true)