Validate experes_at during plan

Author: sudoapt-getclean

gitlab/resource_gitlab_group_membership.go

@@ -40,8 +40,9 @@ func resourceGitlabGroupMembership() *schema.Resource {
 				Required:     true,
 			},
 			"expires_at": {
-				Type:     schema.TypeString, // Format YYYY-MM-DD
-				Optional: true,
+				Type:         schema.TypeString, // Format YYYY-MM-DD
+				ValidateFunc: validateDateFunc(),
+				Optional:     true,
 			},
 		},
 	}

gitlab/resource_gitlab_project_membership.go

@@ -44,14 +44,6 @@ func resourceGitlabProjectMembership() *schema.Resource {
 	}
 }
 
-var accessLevelID = map[string]gitlab.AccessLevelValue{
-	"guest":     gitlab.GuestPermissions,
-	"reporter":  gitlab.ReporterPermissions,
-	"developer": gitlab.DeveloperPermissions,
-	"master":    gitlab.MasterPermissions,
-	"owner":     gitlab.OwnerPermission,
-}
-
 func resourceGitlabProjectMembershipCreate(d *schema.ResourceData, meta interface{}) error {
 	client := meta.(*gitlab.Client)
 

gitlab/util.go

@@ -7,6 +7,7 @@ import (
 	"github.com/xanzy/go-gitlab"
 	"regexp"
 	"strings"
+	"time"
 )
 
 // copied from ../github/util.go
@@ -28,6 +29,18 @@ func validateValueFunc(values []string) schema.SchemaValidateFunc {
 	}
 }
 
+func validateDateFunc() schema.SchemaValidateFunc {
+	return func(v interface{}, k string) (we []string, errors []error) {
+		value := v.(string)
+		//add zero hours and let time figure out correctness
+		_, e := time.Parse(time.RFC3339, value+"T00:00:00Z")
+		if e != nil {
+			errors = append(errors, fmt.Errorf("%s is not valid for format YYYY-MM-DD", value))
+		}
+		return
+	}
+}
+
 func stringToVisibilityLevel(s string) *gitlab.VisibilityValue {
 	lookup := map[string]gitlab.VisibilityValue{
 		"private":  gitlab.PrivateVisibility,
@@ -75,3 +88,11 @@ func parseTwoPartID(id string) (string, string, error) {
 func buildTwoPartID(a, b *string) string {
 	return fmt.Sprintf("%s:%s", *a, *b)
 }
+
+var accessLevelID = map[string]gitlab.AccessLevelValue{
+	"guest":     gitlab.GuestPermissions,
+	"reporter":  gitlab.ReporterPermissions,
+	"developer": gitlab.DeveloperPermissions,
+	"master":    gitlab.MasterPermissions,
+	"owner":     gitlab.OwnerPermission,
+}