44package provider
55
66import (
7- "errors"
87 "fmt"
98 "testing"
109
11- "github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest"
1210 "github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
1311 "github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
14- "github.com/xanzy/go-gitlab"
1512)
1613
1714func TestAccGitlabGroupSamlLink_basic (t * testing.T ) {
18- rInt := acctest .RandInt ()
19- resourceName := "gitlab_group_saml_link.foo"
15+ testAccCheckEE (t )
2016
21- // PreCheck runs after Config so load test data here
22- var samlLink gitlab.SAMLGroupLink
23- testSamlLink := gitlab.SAMLGroupLink {
24- Name : "test_saml_group" ,
25- }
17+ testGroup := testAccCreateGroups (t , 1 )[0 ]
2618
2719 resource .ParallelTest (t , resource.TestCase {
2820 ProviderFactories : providerFactories ,
2921 CheckDestroy : testAccCheckGitlabGroupSamlLinkDestroy ,
3022 Steps : []resource.TestStep {
3123
32- // Create a group SAML link as a developer (uses testAccGitlabGroupLdapSamlCreateConfig for Config)
24+ // Create a group SAML link as a developer
3325 {
34- SkipFunc : isRunningInCE ,
3526 Config : fmt .Sprintf (`
36- resource "gitlab_group_saml_link" "foo" {
37- group_id = "%d"
38- access_level = "Developer"
39- saml_group_name = "%s"
40-
41- }` , rInt , rInt , testSamlLink .Name ),
42- Check : resource .ComposeTestCheckFunc (
43- testAccCheckGitlabGroupSamlLinkExists (resourceName , & samlLink )),
44- },
27+ resource "gitlab_group_saml_link" "this" {
28+ group = "%d"
29+ access_level = "Developer"
30+ saml_group_name = "test_saml_group"
4531
46- // Import the group SAML link (re-uses testAccGitlabGroupSamlLinkCreateConfig for Config)
32+ }
33+ ` , testGroup .ID ),
34+ },
35+ // Verify Import
4736 {
48- SkipFunc : isRunningInCE ,
49- ResourceName : resourceName ,
50- ImportStateIdFunc : getGitlabGroupSamlLinkImportID (resourceName ),
37+ ResourceName : "gitlab_group_saml_link.this" ,
5138 ImportState : true ,
5239 ImportStateVerify : true ,
5340 },
54-
55- // Update the group SAML link to change the access level (uses testAccGitlabGroupSamlLinkUpdateConfig for Config)
41+ // Update the group SAML link to change the access level
5642 {
57- SkipFunc : isRunningInCE ,
5843 Config : fmt .Sprintf (`
59- resource "gitlab_group_saml_link" "foo " {
60- group_id = "%d"
61- access_level = "Maintainer"
62- saml_group_name = "%s "
63- }` , rInt , rInt , testSamlLink . Name ),
64- Check : resource . ComposeTestCheckFunc (
65- testAccCheckGitlabGroupSamlLinkExists ( resourceName , & samlLink ) ),
44+ resource "gitlab_group_saml_link" "this " {
45+ group = "%d"
46+ access_level = "Maintainer"
47+ saml_group_name = "test_saml_group "
48+
49+ }
50+ ` , testGroup . ID ),
6651 },
6752 },
6853 })
6954}
7055
71- func getGitlabGroupSamlLinkImportID (resourceName string ) resource.ImportStateIdFunc {
72- return func (s * terraform.State ) (string , error ) {
73- rs , ok := s .RootModule ().Resources [resourceName ]
74- if ! ok {
75- return "" , fmt .Errorf ("Not Found: %s" , resourceName )
76- }
77-
78- groupID := rs .Primary .Attributes ["group_id" ]
79- if groupID == "" {
80- return "" , fmt .Errorf ("No group ID is set" )
81- }
82- samlGroupName := rs .Primary .Attributes ["saml_group_name" ]
83- if samlGroupName == "" {
84- return "" , fmt .Errorf ("No SAML group name is set" )
85- }
86-
87- return fmt .Sprintf ("%s:%s" , groupID , samlGroupName ), nil
88- }
89- }
90-
91- func testAccCheckGitlabGroupSamlLinkExists (resourceName string , samlLink * gitlab.SAMLGroupLink ) resource.TestCheckFunc {
92- return func (s * terraform.State ) error {
93- // Clear the "found" SAML link before checking for existence
94- * samlLink = gitlab.SAMLGroupLink {}
95-
96- resourceState , ok := s .RootModule ().Resources [resourceName ]
97- if ! ok {
98- return fmt .Errorf ("Not found: %s" , resourceName )
56+ func testAccCheckGitlabGroupSamlLinkDestroy (s * terraform.State ) error {
57+ for _ , resourceState := range s .RootModule ().Resources {
58+ if resourceState .Type != "gitlab_group_saml_link" {
59+ continue
9960 }
10061
101- err := testAccGetGitlabGroupSamlLink ( samlLink , resourceState )
62+ group , samlGroupName , err := parseTwoPartID ( resourceState . Primary . ID )
10263 if err != nil {
10364 return err
10465 }
10566
106- return nil
107- }
108- }
109-
110- func testAccCheckGitlabGroupSamlLinkDestroy (s * terraform.State ) error {
111- // Can't check for links if the group is destroyed so make sure all groups are destroyed instead
112- for _ , resourceState := range s .RootModule ().Resources {
113- if resourceState .Type != "gitlab_group" {
114- continue
115- }
116-
117- group , _ , err := testGitlabClient .Groups .GetGroup (resourceState .Primary .ID , nil )
67+ samlGroupLink , _ , err := testGitlabClient .Groups .GetGroupSAMLLink (group , samlGroupName )
11868 if err == nil {
119- if group != nil && fmt .Sprintf ("%d" , group .ID ) == resourceState .Primary .ID {
120- if group .MarkedForDeletionOn == nil {
121- return fmt .Errorf ("Group still exists" )
122- }
69+ if samlGroupLink != nil {
70+ return fmt .Errorf ("SAML Group Link still exists" )
12371 }
12472 }
12573 if ! is404 (err ) {
@@ -129,41 +77,3 @@ func testAccCheckGitlabGroupSamlLinkDestroy(s *terraform.State) error {
12977 }
13078 return nil
13179}
132-
133- func testAccGetGitlabGroupSamlLink (samlLink * gitlab.SAMLGroupLink , resourceState * terraform.ResourceState ) error {
134- groupId := resourceState .Primary .Attributes ["group_id" ]
135- if groupId == "" {
136- return fmt .Errorf ("No group ID is set" )
137- }
138-
139- // Construct our desired SAML Link from the config values
140- desiredSamlLink := gitlab.SAMLGroupLink {
141- AccessLevel : resourceState .Primary .Attributes ["access_level" ],
142- Name : resourceState .Primary .Attributes ["saml_group_name" ],
143- }
144-
145- desiredSamlLinkId := buildTwoPartID (& groupId , & desiredSamlLink .Name )
146-
147- // Try to fetch all group links from GitLab
148- currentSamlLinks , _ , err := testGitlabClient .Groups .ListGroupSamlLinks (groupId , nil )
149- if err != nil {
150- return err
151- }
152-
153- found := false
154-
155- // Check if the SAML link exists in the returned list of links
156- for _ , currentSamlLink := range currentSamlLinks {
157- if buildTwoPartID (& groupId , & currentSamlLink .Name ) == desiredSamlLinkId {
158- found = true
159- * samlLink = * currentSamlLink
160- break
161- }
162- }
163-
164- if ! found {
165- return errors .New (fmt .Sprintf ("SamlLink %s does not exist." , desiredSamlLinkId )) // nolint // TODO: Resolve this golangci-lint issue: S1028: should use fmt.Errorf(...) instead of errors.New(fmt.Sprintf(...)) (gosimple)
166- }
167-
168- return nil
169- }
0 commit comments