Feedback

Author: SharaevN

internal/provider/data_source_gitlab_release_links.go

@@ -19,7 +19,7 @@ var _ = registerDataSource("gitlab_release_links", func() *schema.Resource {
 		ReadContext: dataSourceGitlabReleaseLinksRead,
 		Schema: map[string]*schema.Schema{
 			"project": {
-				Description: "The ID or [URL-encoded path of the project](https://docs.gitlab.com/ee/api/index.html#namespaced-path-encoding).",
+				Description: "The ID or full path to the project.",
 				Type:        schema.TypeString,
 				Required:    true,
 				ForceNew:    true,
@@ -69,8 +69,7 @@ func dataSourceGitlabReleaseLinksRead(ctx context.Context, d *schema.ResourceDat
 
 	log.Printf("[DEBUG] get list release links project/tagName: %s/%s", project, tagName)
 	d.SetId(buildTwoPartID(&project, &tagName))
-	var err error
-	if err = d.Set("release_links", flattenGitlabReleaseLinks(project, tagName, releaseLinks)); err != nil {
+    if err := d.Set("release_links", flattenGitlabReleaseLinks(project, tagName, releaseLinks)); err != nil {
 		return diag.Errorf("Failed to set release links to state: %v", err)
 	}
 

internal/provider/resource_gitlab_release_link.go

@@ -9,12 +9,12 @@ import (
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
-	gitlab "github.com/xanzy/go-gitlab"
+	"github.com/xanzy/go-gitlab"
 )
 
 var _ = registerResource("gitlab_release_link", func() *schema.Resource {
 	return &schema.Resource{
-		Description: `The ` + "`gitlab_release_link`" + ` resource allows to manage the lifecycle of a release links.
+		Description: `The ` + "`gitlab_release_link`" + ` resource allows to manage the lifecycle of a release link.
 
 **Upstream API**: [GitLab REST API docs](https://docs.gitlab.com/ee/api/releases/links.html)`,
 
@@ -37,8 +37,8 @@ func resourceGitlabReleaseLinkCreate(ctx context.Context, d *schema.ResourceData
 	url := d.Get("url").(string)
 
 	options := &gitlab.CreateReleaseLinkOptions{
-		Name: &name,
-		URL:  &url,
+		Name: gitlab.String(name),
+		URL:  gitlab.String(url),
 	}
 	if filePath, ok := d.GetOk("filepath"); ok {
 		options.FilePath = gitlab.String(filePath.(string))