add build coverage regex (#627)

* add build coverage regex

* fmt

* modify data source and tests

* modify doc

* fmt

* Feature (#1)

* Fix documentation to show up on terraform registry

* update reference to `master` branch to `main`

Tested to confirm that it does create a `main` branch by default

* Add support for importing Pipeline Schedules and Triggers

* Also wait for import_status when a project template is configured

Signed-off-by: Sune Keller <[email protected]>

* Update dependencies

Signed-off-by: Julien Pivotto <[email protected]>

* Add most Premium features for gitlab_branch_protection (#556)

* Rebase and update go.mod

Signed-off-by: Sune Keller <[email protected]>

* Add most Premium features for gitlab_branch_protection

Signed-off-by: Sune Keller <[email protected]>

* Re-work modified schema for gitlab_branch_protection, and update docs

Signed-off-by: Sune Keller <[email protected]>

* Accommodate to name changes from library maintainer

Signed-off-by: Sune Keller <[email protected]>

* Remove invalid check for CE

Signed-off-by: Sune Keller <[email protected]>

* Revert back how merge_access_level and push_access_level are created

Signed-off-by: Sune Keller <[email protected]>

* Simplify expansion of arguments

Signed-off-by: Sune Keller <[email protected]>

* Remove several obsolete functions and make acceptance tests independent of implementation functions

Signed-off-by: Sune Keller <[email protected]>

* fix: update default_branch to "main" for gitlab_project tests

* chore: add error handling to resourceGitlabProjectSetToState

* Documentation improvements (#642)

* Documentation improvements

* More Markdown lint fixes

* Add golangci-lint to the pipeline

Fixes #361

* Add protected_branch_ids to gitlab_project_approval_rule (#542)

Signed-off-by: Sune Keller <[email protected]>

* chore: remove incomplete gitlab_project_repository_file resource (#650)

This file was part of #556 but did not include a test, docs, or an entry in gitlab/provider.go, so we are removing it until it can be completed.

* golangci-lint: exclude ResourceData.Set (#652)

The common case when using this method is to ignore the error return. This is because the Terraform test framework checks these errors for primitive types for us.

* CI: Add tfproviderlint workflow

* Ignore preexisting tfproviderlint issues

* chore: run golangci-lint for pull requests and annotate failing checks so we can fix them individually (#658)

* chore: fix markdown linter errors in branch_protection.md (#656)

* modify

Co-authored-by: Denis Doria <[email protected]>
Co-authored-by: Daniel Hill <[email protected]>
Co-authored-by: Patrick Decat <[email protected]>
Co-authored-by: Sune Keller <[email protected]>
Co-authored-by: Julien Pivotto <[email protected]>
Co-authored-by: Matt Kasa <[email protected]>
Co-authored-by: Mikhail Mazurskiy <[email protected]>
Co-authored-by: Willian Paixao <[email protected]>
Co-authored-by: Matt Kasa <[email protected]>
Co-authored-by: Adam Snyder <[email protected]>
Co-authored-by: Adam Snyder <[email protected]>

Co-authored-by: Denis Doria <[email protected]>
Co-authored-by: Daniel Hill <[email protected]>
Co-authored-by: Patrick Decat <[email protected]>
Co-authored-by: Sune Keller <[email protected]>
Co-authored-by: Julien Pivotto <[email protected]>
Co-authored-by: Matt Kasa <[email protected]>
Co-authored-by: Mikhail Mazurskiy <[email protected]>
Co-authored-by: Willian Paixao <[email protected]>
Co-authored-by: Matt Kasa <[email protected]>
Co-authored-by: Adam Snyder <[email protected]>
Co-authored-by: Adam Snyder <[email protected]>

Author: 10 people

docs/data-sources/projects.md

@@ -190,6 +190,8 @@ Projects items have the following fields:
 
 * `custom_attributes`
 
+* `build_coverage_regex`
+
 The `owner` attribute exposes the following sub-attributes:
 
 > **NOTE**: These sub-attributes are only populated if the Gitlab token used has an administrator scope.

docs/resources/project.md

@@ -105,6 +105,8 @@ consult the [gitlab documentation](https://docs.gitlab.com/ee/user/project/repos
   Valid values are `disabled`, `private`, `enabled`, `public`.
   `private` is the default.
 
+* `build_coverage_regex` - (Optional) Test coverage parsing for the project.
+
 ## Attributes Reference
 
 The following additional attributes are exported:

gitlab/data_source_gitlab_projects.go

@@ -160,6 +160,7 @@ func flattenProjects(projects []*gitlab.Project) (values []map[string]interface{
 				"ci_config_path":                      project.CIConfigPath,
 				"custom_attributes":                   project.CustomAttributes,
 				"packages_enabled":                    project.PackagesEnabled,
+				"build_coverage_regex":                project.BuildCoverageRegex,
 			}
 			values = append(values, v)
 		}
@@ -658,6 +659,10 @@ func dataSourceGitlabProjects() *schema.Resource {
 							Type:     schema.TypeBool,
 							Computed: true,
 						},
+						"build_coverage_regex": {
+							Type:     schema.TypeString,
+							Computed: true,
+						},
 					},
 				},
 			},

gitlab/resource_gitlab_project.go

@@ -295,6 +295,10 @@ var resourceGitLabProjectSchema = map[string]*schema.Schema{
 		Optional: true,
 		Default:  false,
 	},
+	"build_coverage_regex": {
+		Type:     schema.TypeString,
+		Optional: true,
+	},
 }
 
 func resourceGitlabProject() *schema.Resource {
@@ -346,6 +350,7 @@ func resourceGitlabProjectSetToState(d *schema.ResourceData, project *gitlab.Pro
 		"mirror_trigger_builds":               project.MirrorTriggerBuilds,
 		"mirror_overwrites_diverged_branches": project.MirrorOverwritesDivergedBranches,
 		"only_mirror_protected_branches":      project.OnlyMirrorProtectedBranches,
+		"build_coverage_regex":                project.BuildCoverageRegex,
 	}
 	return setResourceData(d, values)
 }
@@ -373,6 +378,7 @@ func resourceGitlabProjectCreate(d *schema.ResourceData, meta interface{}) error
 		PackagesEnabled:                           gitlab.Bool(d.Get("packages_enabled").(bool)),
 		Mirror:                                    gitlab.Bool(d.Get("mirror").(bool)),
 		MirrorTriggerBuilds:                       gitlab.Bool(d.Get("mirror_trigger_builds").(bool)),
+		BuildCoverageRegex:                        gitlab.String(d.Get("build_coverage_regex").(string)),
 	}
 
 	if v, ok := d.GetOk("path"); ok {
@@ -641,6 +647,10 @@ func resourceGitlabProjectUpdate(d *schema.ResourceData, meta interface{}) error
 		options.MirrorOverwritesDivergedBranches = gitlab.Bool(d.Get("mirror_overwrites_diverged_branches").(bool))
 	}
 
+	if d.HasChange("build_coverage_regex") {
+		options.BuildCoverageRegex = gitlab.String(d.Get("build_coverage_regex").(string))
+	}
+
 	if *options != (gitlab.EditProjectOptions{}) {
 		log.Printf("[DEBUG] update gitlab project %s", d.Id())
 		_, _, err := client.Projects.EditProject(d.Id(), options)

gitlab/resource_gitlab_project_test.go

@@ -43,9 +43,10 @@ func TestAccGitlabProject_basic(t *testing.T) {
 		MergeMethod:                      gitlab.FastForwardMerge,
 		OnlyAllowMergeIfPipelineSucceeds: true,
 		OnlyAllowMergeIfAllDiscussionsAreResolved: true,
-		Archived:         false, // needless, but let's make this explicit
-		PackagesEnabled:  true,
-		PagesAccessLevel: gitlab.PublicAccessControl,
+		Archived:           false, // needless, but let's make this explicit
+		PackagesEnabled:    true,
+		PagesAccessLevel:   gitlab.PublicAccessControl,
+		BuildCoverageRegex: "foo",
 	}
 
 	defaultsMainBranch = defaults
@@ -85,9 +86,10 @@ func TestAccGitlabProject_basic(t *testing.T) {
 						MergeMethod:                      gitlab.FastForwardMerge,
 						OnlyAllowMergeIfPipelineSucceeds: true,
 						OnlyAllowMergeIfAllDiscussionsAreResolved: true,
-						Archived:         true,
-						PackagesEnabled:  false,
-						PagesAccessLevel: gitlab.DisabledAccessControl,
+						Archived:           true,
+						PackagesEnabled:    false,
+						PagesAccessLevel:   gitlab.DisabledAccessControl,
+						BuildCoverageRegex: "bar",
 					}, &received),
 				),
 			},
@@ -358,8 +360,9 @@ func TestAccGitlabProject_willError(t *testing.T) {
 		MergeMethod:                      gitlab.FastForwardMerge,
 		OnlyAllowMergeIfPipelineSucceeds: true,
 		OnlyAllowMergeIfAllDiscussionsAreResolved: true,
-		PackagesEnabled:  true,
-		PagesAccessLevel: gitlab.PublicAccessControl,
+		PackagesEnabled:    true,
+		PagesAccessLevel:   gitlab.PublicAccessControl,
+		BuildCoverageRegex: "foo",
 	}
 	willError := defaults
 	willError.TagList = []string{"notatag"}
@@ -459,8 +462,9 @@ func TestAccGitlabProject_transfer(t *testing.T) {
 		MergeMethod:                      gitlab.NoFastForwardMerge,
 		OnlyAllowMergeIfPipelineSucceeds: false,
 		OnlyAllowMergeIfAllDiscussionsAreResolved: false,
-		PackagesEnabled:  true,
-		PagesAccessLevel: gitlab.PrivateAccessControl,
+		PackagesEnabled:    true,
+		PagesAccessLevel:   gitlab.PrivateAccessControl,
+		BuildCoverageRegex: "foo",
 	}
 
 	resource.Test(t, resource.TestCase{
@@ -887,6 +891,7 @@ resource "gitlab_project" "foo" {
   # So that acceptance tests can be run in a gitlab organization
   # with no billing
   visibility_level = "public"
+  build_coverage_regex = "foo"
 }
 	`, rInt, rInt, rInt)
 }
@@ -913,6 +918,7 @@ resource "gitlab_project" "foo" {
   # So that acceptance tests can be run in a gitlab organization
   # with no billing
   visibility_level = "public"
+  build_coverage_regex = "foo"
 }
 	`, rInt, rInt, rInt, rInt, rInt)
 }
@@ -943,6 +949,7 @@ resource "gitlab_project" "foo" {
   only_allow_merge_if_pipeline_succeeds = true
   only_allow_merge_if_all_discussions_are_resolved = true
   pages_access_level = "public"
+  build_coverage_regex = "foo"
 }
 	`, rInt, rInt, defaultBranchStatement)
 }
@@ -1010,6 +1017,7 @@ resource "gitlab_project" "foo" {
   archived = true
   packages_enabled = false
   pages_access_level = "disabled"
+  build_coverage_regex = "bar"
 }
 	`, rInt, rInt)
 }