gitlab_group: Revert recent change to visibility_level attribute (#408)

* gitlab_group: Revert recent change to visibility_level attribute

* Update group.html.markdown

* Update group.html.markdown

* Update group.html.markdown

Author: armsnyder

CHANGELOG.md

@@ -1,8 +1,5 @@
 ## 2.12.0 (Unreleased)
 
-NOTES:
-* resource/gitlab_group: Attribute `visibility_level` now defaults to `private`, as was already documented, instead of reading the default from GitLab. This will not affect existing state. [GH-362]
-
 FEATURES:
 * **New Data Source:** `gitlab_group_membership` [GH-264]
 * **New Resource:** `gitlab_project_level_mr_approvals` [GH-356]

gitlab/resource_gitlab_group.go

@@ -61,7 +61,7 @@ func resourceGitlabGroup() *schema.Resource {
 			"visibility_level": {
 				Type:         schema.TypeString,
 				Optional:     true,
-				Default:      "private",
+				Computed:     true,
 				ValidateFunc: validation.StringInSlice([]string{"private", "internal", "public"}, true),
 			},
 			"share_with_group_lock": {

website/docs/r/group.html.markdown

@@ -44,9 +44,7 @@ support for projects in this group.
 * `request_access_enabled` - (Optional) Boolean, defaults to false.  Whether to
 enable users to request access to the group.
 
-* `visibility_level` - (Optional) Set to `public` to create a public group.
-  Valid values are `private`, `internal`, `public`.
-  Groups are created as private by default.
+* `visibility_level` - (Optional) The group's visibility. Can be `private`, `internal`, or `public`.
 
 * `share_with_group_lock` - (Optional) Boolean, defaults to false.  Prevent sharing
 a project with another group within this group.