Merge pull request #982 from StingRayZA/docs-fix

Update group resource inline docs

Author: timofurrer

docs/resources/group.md

@@ -43,21 +43,21 @@ resource "gitlab_project" "example" {
 
 ### Optional
 
-- `auto_devops_enabled` (Boolean) Boolean, defaults to false.  Default to Auto
-- `default_branch_protection` (Number) Int, defaults to 2.
+- `auto_devops_enabled` (Boolean) Defaults to false. Default to Auto DevOps pipeline for all projects within this group.
+- `default_branch_protection` (Number) Defaults to 2. See https://docs.gitlab.com/ee/api/groups.html#options-for-default_branch_protection
 - `description` (String) The description of the group.
-- `emails_disabled` (Boolean) Boolean, defaults to false.  Disable email notifications
+- `emails_disabled` (Boolean) Defaults to false. Disable email notifications.
 - `id` (String) The ID of this resource.
-- `lfs_enabled` (Boolean) Boolean, defaults to true.  Whether to enable LFS
-- `mentions_disabled` (Boolean) Boolean, defaults to false.  Disable the capability
-- `parent_id` (Number) Integer, id of the parent group (creates a nested group).
-- `prevent_forking_outside_group` (Boolean) When enabled, users can not fork projects from this group to external namespaces.
-- `project_creation_level` (String) , defaults to Maintainer.
-- `request_access_enabled` (Boolean) Boolean, defaults to false.  Whether to
-- `require_two_factor_authentication` (Boolean) Boolean, defaults to false.
-- `share_with_group_lock` (Boolean) Boolean, defaults to false.  Prevent sharing
-- `subgroup_creation_level` (String) , defaults to Owner.
-- `two_factor_grace_period` (Number) Int, defaults to 48.
+- `lfs_enabled` (Boolean) Defaults to true. Enable/disable Large File Storage (LFS) for the projects in this group.
+- `mentions_disabled` (Boolean) Defaults to false. Disable the capability of a group from getting mentioned.
+- `parent_id` (Number) Id of the parent group (creates a nested group).
+- `prevent_forking_outside_group` (Boolean) Defaults to false. When enabled, users can not fork projects from this group to external namespaces.
+- `project_creation_level` (String) Defaults to maintainer. Determine if developers can create projects in the group.
+- `request_access_enabled` (Boolean) Defaults to false. Allow users to request member access.
+- `require_two_factor_authentication` (Boolean) Defaults to false. Require all users in this group to setup Two-factor authentication.
+- `share_with_group_lock` (Boolean) Defaults to false. Prevent sharing a project with another group within this group.
+- `subgroup_creation_level` (String) Defaults to owner. Allowed to create subgroups.
+- `two_factor_grace_period` (Number) Defaults to 48. Time before Two-factor authentication is enforced (in hours).
 - `visibility_level` (String) The group's visibility. Can be `private`, `internal`, or `public`.
 
 ### Read-Only

internal/provider/resource_gitlab_group.go

@@ -63,20 +63,20 @@ var _ = registerResource("gitlab_group", func() *schema.Resource {
 				Optional:    true,
 			},
 			"lfs_enabled": {
-				Description: "Boolean, defaults to true.  Whether to enable LFS",
+				Description: "Defaults to true. Enable/disable Large File Storage (LFS) for the projects in this group.",
 				Type:        schema.TypeBool,
 				Optional:    true,
 				Default:     true,
 			},
 			"default_branch_protection": {
-				Description:  "Int, defaults to 2.",
+				Description:  "Defaults to 2. See https://docs.gitlab.com/ee/api/groups.html#options-for-default_branch_protection",
 				Type:         schema.TypeInt,
 				Optional:     true,
 				Default:      2,
 				ValidateFunc: validation.IntInSlice([]int{0, 1, 2}),
 			},
 			"request_access_enabled": {
-				Description: "Boolean, defaults to false.  Whether to",
+				Description: "Defaults to false. Allow users to request member access.",
 				Type:        schema.TypeBool,
 				Optional:    true,
 				Default:     false,
@@ -89,57 +89,57 @@ var _ = registerResource("gitlab_group", func() *schema.Resource {
 				ValidateFunc: validation.StringInSlice([]string{"private", "internal", "public"}, true),
 			},
 			"share_with_group_lock": {
-				Description: "Boolean, defaults to false.  Prevent sharing",
+				Description: "Defaults to false. Prevent sharing a project with another group within this group.",
 				Type:        schema.TypeBool,
 				Optional:    true,
 				Default:     false,
 			},
 			"project_creation_level": {
-				Description:  ", defaults to Maintainer.",
+				Description:  "Defaults to maintainer. Determine if developers can create projects in the group.",
 				Type:         schema.TypeString,
 				Optional:     true,
 				Default:      "maintainer",
 				ValidateFunc: validation.StringInSlice([]string{"noone", "maintainer", "developer"}, true),
 			},
 			"auto_devops_enabled": {
-				Description: "Boolean, defaults to false.  Default to Auto",
+				Description: "Defaults to false. Default to Auto DevOps pipeline for all projects within this group.",
 				Type:        schema.TypeBool,
 				Optional:    true,
 				Default:     false,
 			},
 			"emails_disabled": {
-				Description: "Boolean, defaults to false.  Disable email notifications",
+				Description: "Defaults to false. Disable email notifications.",
 				Type:        schema.TypeBool,
 				Optional:    true,
 				Default:     false,
 			},
 			"mentions_disabled": {
-				Description: "Boolean, defaults to false.  Disable the capability",
+				Description: "Defaults to false. Disable the capability of a group from getting mentioned.",
 				Type:        schema.TypeBool,
 				Optional:    true,
 				Default:     false,
 			},
 			"subgroup_creation_level": {
-				Description:  ", defaults to Owner.",
+				Description:  "Defaults to owner. Allowed to create subgroups.",
 				Type:         schema.TypeString,
 				Optional:     true,
 				Default:      "owner",
 				ValidateFunc: validation.StringInSlice([]string{"owner", "maintainer"}, true),
 			},
 			"require_two_factor_authentication": {
-				Description: "Boolean, defaults to false.",
+				Description: "Defaults to false. Require all users in this group to setup Two-factor authentication.",
 				Type:        schema.TypeBool,
 				Optional:    true,
 				Default:     false,
 			},
 			"two_factor_grace_period": {
-				Description: "Int, defaults to 48.",
+				Description: "Defaults to 48. Time before Two-factor authentication is enforced (in hours).",
 				Type:        schema.TypeInt,
 				Optional:    true,
 				Default:     48,
 			},
 			"parent_id": {
-				Description: "Integer, id of the parent group (creates a nested group).",
+				Description: "Id of the parent group (creates a nested group).",
 				Type:        schema.TypeInt,
 				Optional:    true,
 				ForceNew:    true,
@@ -152,7 +152,7 @@ var _ = registerResource("gitlab_group", func() *schema.Resource {
 				Sensitive:   true,
 			},
 			"prevent_forking_outside_group": {
-				Description: "When enabled, users can not fork projects from this group to external namespaces.",
+				Description: "Defaults to false. When enabled, users can not fork projects from this group to external namespaces.",
 				Type:        schema.TypeBool,
 				Optional:    true,
 				Default:     false,