Fix the mirror-exists check in the mirror test (#425)

armsnyder · web-flow · commit 3b6f82bd5c4f · 2020-09-21T11:26:12.000+02:00
diff --git a/gitlab/resource_gitlab_project_mirror_test.go b/gitlab/resource_gitlab_project_mirror_test.go
@@ -112,11 +112,10 @@ func testAccCheckGitlabProjectMirrorExists(n string, mirror *gitlab.ProjectMirro
 		for _, m := range mirrors {
 			if m.ID == mirrorID {
 				*mirror = *m
-				break
+				return nil
 			}
-			return errors.New("unable to find mirror.")
 		}
-		return nil
+		return errors.New("unable to find mirror")
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -112,11 +112,10 @@ func testAccCheckGitlabProjectMirrorExists(n string, mirror *gitlab.ProjectMirro`
`112`	`112`	`for _, m := range mirrors {`
`113`	`113`	`if m.ID == mirrorID {`
`114`	`114`	`mirror = m`
`115`		`- break`
	`115`	`+ return nil`
`116`	`116`	`}`
`117`		`- return errors.New("unable to find mirror.")`
`118`	`117`	`}`
`119`		`- return nil`
	`118`	`+ return errors.New("unable to find mirror")`
`120`	`119`	`}`
`121`	`120`	`}`
`122`	`121`