Skip to content

Commit 42fd769

Browse files
authored
Merge pull request #402 from gitlabhq/fix-project-level-mr-approvals-2
Fix project_id not being set in gitlab_project_level_mr_approvals
2 parents 3f6ea13 + c83e106 commit 42fd769

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

gitlab/resource_gitlab_project_level_mr_approvals.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,12 @@ func resourceGitlabProjectLevelMRApprovalsCreate(d *schema.ResourceData, meta in
6969
func resourceGitlabProjectLevelMRApprovalsRead(d *schema.ResourceData, meta interface{}) error {
7070
client := meta.(*gitlab.Client)
7171

72-
projectId := d.Id()
73-
log.Printf("[DEBUG] Reading gitlab approval configuration for project %s", projectId)
72+
projectId, err := strconv.Atoi(d.Id())
73+
if err != nil {
74+
return fmt.Errorf("project ID must be an integer (was %q): %w", d.Id(), err)
75+
}
76+
77+
log.Printf("[DEBUG] Reading gitlab approval configuration for project %q", projectId)
7478

7579
approvalConfig, _, err := client.Projects.GetApprovalConfiguration(projectId)
7680
if err != nil {

0 commit comments

Comments
 (0)