Merge pull request #1218 from amine7536/fix-ci_forward_deployment_enabled

resource/gitlab_project: Fix passing `ci_forward_deployment_enabled=false` at project creation

Author: timofurrer

internal/provider/resource_gitlab_project.go

@@ -810,7 +810,6 @@ func resourceGitlabProjectCreate(ctx context.Context, d *schema.ResourceData, me
 		Mirror:                                    gitlab.Bool(d.Get("mirror").(bool)),
 		MirrorTriggerBuilds:                       gitlab.Bool(d.Get("mirror_trigger_builds").(bool)),
 		CIConfigPath:                              gitlab.String(d.Get("ci_config_path").(string)),
-		CIForwardDeploymentEnabled:                gitlab.Bool(d.Get("ci_forward_deployment_enabled").(bool)),
 	}
 
 	if v, ok := d.GetOk("build_coverage_regex"); ok {
@@ -1204,6 +1203,12 @@ func resourceGitlabProjectCreate(ctx context.Context, d *schema.ResourceData, me
 		editProjectOptions.CIDefaultGitDepth = gitlab.Int(v.(int))
 	}
 
+	// nolint:staticcheck // SA1019 ignore deprecated GetOkExists
+	// lintignore: XR001 // TODO: replace with alternative for GetOkExists
+	if v, ok := d.GetOkExists("ci_forward_deployment_enabled"); ok {
+		editProjectOptions.CIForwardDeploymentEnabled = gitlab.Bool(v.(bool))
+	}
+
 	if (editProjectOptions != gitlab.EditProjectOptions{}) {
 		if _, _, err := client.Projects.EditProject(d.Id(), &editProjectOptions, gitlab.WithContext(ctx)); err != nil {
 			return diag.Errorf("Could not update project %q: %s", d.Id(), err)

internal/provider/resource_gitlab_project_test.go

@@ -1377,6 +1377,7 @@ func TestAccGitlabProject_SetDefaultFalseBooleansOnCreate(t *testing.T) {
 						public_builds                       = false
 						merge_pipelines_enabled             = false
 						merge_trains_enabled                = false
+						ci_forward_deployment_enabled       = false
 					}`, rInt),
 			},
 			{