Skip to content

Commit a26d149

Browse files
committed
Use context-aware CRUD functions for Users data source
1 parent d28faa3 commit a26d149

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

gitlab/data_source_gitlab_users.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,21 @@
11
package gitlab
22

33
import (
4+
"context"
45
"fmt"
56
"strconv"
67
"strings"
78
"time"
89

10+
"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
911
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
1012
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
1113
gitlab "github.com/xanzy/go-gitlab"
1214
)
1315

1416
func dataSourceGitlabUsers() *schema.Resource {
1517
return &schema.Resource{
16-
Read: dataSourceGitlabUsersRead,
18+
ReadContext: dataSourceGitlabUsersRead,
1719

1820
Schema: map[string]*schema.Schema{
1921
"order_by": {
@@ -173,21 +175,21 @@ func dataSourceGitlabUsers() *schema.Resource {
173175
}
174176
}
175177

176-
func dataSourceGitlabUsersRead(d *schema.ResourceData, meta interface{}) error {
178+
func dataSourceGitlabUsersRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
177179
client := meta.(*gitlab.Client)
178180

179181
listUsersOptions, id, err := expandGitlabUsersOptions(d)
180182
if err != nil {
181-
return err
183+
return diag.FromErr(err)
182184
}
183185
page := 1
184186
userslen := 0
185187
var users []*gitlab.User
186188
for page == 1 || userslen != 0 {
187189
listUsersOptions.Page = page
188-
paginatedUsers, _, err := client.Users.ListUsers(listUsersOptions)
190+
paginatedUsers, _, err := client.Users.ListUsers(listUsersOptions, gitlab.WithContext(ctx))
189191
if err != nil {
190-
return err
192+
return diag.FromErr(err)
191193
}
192194
users = append(users, paginatedUsers...)
193195
userslen = len(paginatedUsers)

0 commit comments

Comments
 (0)