Add parallel tests and empty data source list

Author: SharaevN

docs/data-sources/release_link.md

@@ -44,9 +44,9 @@ data "gitlab_release_link" "example" {
 
 - `direct_asset_url` (String) Full path for a [Direct Asset link](https://docs.gitlab.com/ee/user/project/releases/index.html#permanent-links-to-release-assets).
 - `external` (Boolean) External or internal link.
-- `filepath` (String) Relatively path for a [Direct Asset link](https://docs.gitlab.com/ee/user/project/releases/index.html#permanent-links-to-release-assets).
+- `filepath` (String) Relative path for a [Direct Asset link](https://docs.gitlab.com/ee/user/project/releases/index.html#permanent-links-to-release-assets).
 - `id` (String) The ID of this resource.
-- `link_type` (String) The type of the link: `other`, `runbook`, `image`, `package`. Defaults to other.
+- `link_type` (String) The type of the link. Valid values are `other`, `runbook`, `image`, `package`. Defaults to other.
 - `name` (String) The name of the link. Link names must be unique within the release.
 - `url` (String) The URL of the link. Link URLs must be unique within the release.
 

docs/resources/release_link.md

@@ -43,8 +43,8 @@ resource "gitlab_release_link" "example" {
 
 ### Optional
 
-- `filepath` (String) Relatively path for a [Direct Asset link](https://docs.gitlab.com/ee/user/project/releases/index.html#permanent-links-to-release-assets).
-- `link_type` (String) The type of the link: `other`, `runbook`, `image`, `package`. Defaults to other.
+- `filepath` (String) Relative path for a [Direct Asset link](https://docs.gitlab.com/ee/user/project/releases/index.html#permanent-links-to-release-assets).
+- `link_type` (String) The type of the link. Valid values are `other`, `runbook`, `image`, `package`. Defaults to other.
 
 ### Read-Only
 

internal/provider/data_source_gitlab_release_link_test.go

@@ -15,7 +15,7 @@ func TestAccDataSourceGitlabReleaseLink_basic(t *testing.T) {
 	project := testAccCreateProject(t)
 	releases := testAccCreateReleases(t, project, 2)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		ProviderFactories: providerFactories,
 		Steps: []resource.TestStep{
 			{

internal/provider/data_source_gitlab_release_links.go

@@ -57,9 +57,12 @@ func dataSourceGitlabReleaseLinksRead(ctx context.Context, d *schema.ResourceDat
 	for options.Page != 0 {
 		paginatedReleaseLinks, resp, err := client.ReleaseLinks.ListReleaseLinks(project, tagName, &options, gitlab.WithContext(ctx))
 		if err != nil {
-			return diag.FromErr(err)
+			if is404(err) {
+				break
+			} else {
+				return diag.FromErr(err)
+			}
 		}
-
 		releaseLinks = append(releaseLinks, paginatedReleaseLinks...)
 		options.Page = resp.NextPage
 	}

internal/provider/data_source_gitlab_release_links_test.go

@@ -15,7 +15,7 @@ func TestAccDataGitlabReleaseLinks_basic(t *testing.T) {
 	project := testAccCreateProject(t)
 	releases := testAccCreateReleases(t, project, 2)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		ProviderFactories: providerFactories,
 		Steps: []resource.TestStep{
 			{
@@ -52,6 +52,17 @@ func TestAccDataGitlabReleaseLinks_basic(t *testing.T) {
 					resource.TestCheckResourceAttr("data.gitlab_release_links.this", "release_links.1.direct_asset_url", releases[1].Assets.Links[1].DirectAssetURL),
 				),
 			},
+			{
+				// get empty list
+				Config: fmt.Sprintf(`
+				data "gitlab_release_links" "this" {
+					project = "%s"
+					tag_name = "%s"
+				}`, project.PathWithNamespace, "error_tag"),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("data.gitlab_release_links.this", "release_links.#", fmt.Sprintf("%v", 0)),
+				),
+			},
 		},
 	})
 }

internal/provider/resource_gitlab_release_link_test.go

@@ -19,7 +19,7 @@ func TestAccGitlabReleaseLink_basic(t *testing.T) {
 	project := testAccCreateProject(t)
 	releases := testAccCreateReleases(t, project, 1)
 
-	resource.Test(t, resource.TestCase{
+	resource.ParallelTest(t, resource.TestCase{
 		ProviderFactories: providerFactories,
 		CheckDestroy:      testAccCheckGitlabReleaseLinkDestroy,
 		Steps: []resource.TestStep{

internal/provider/schema_gitlab_release_link.go

@@ -35,12 +35,12 @@ func gitlabReleaseLinkGetSchema() map[string]*schema.Schema {
 			Required:    true,
 		},
 		"filepath": {
-			Description: "Relatively path for a [Direct Asset link](https://docs.gitlab.com/ee/user/project/releases/index.html#permanent-links-to-release-assets).",
+			Description: "Relative path for a [Direct Asset link](https://docs.gitlab.com/ee/user/project/releases/index.html#permanent-links-to-release-assets).",
 			Type:        schema.TypeString,
 			Optional:    true,
 		},
 		"link_type": {
-			Description:      fmt.Sprintf("The type of the link: %s. Defaults to %s.", renderValueListForDocs(validLinkTypes), validLinkTypes[0]),
+			Description:      fmt.Sprintf("The type of the link. Valid values are %s. Defaults to %s.", renderValueListForDocs(validLinkTypes), validLinkTypes[0]),
 			Type:             schema.TypeString,
 			Optional:         true,
 			Default:          validLinkTypes[0],