Merge pull request #999 from defreng/main

add "owner" as valid access level for the group_access_token resource

Author: timofurrer

docs/resources/group_access_token.md

@@ -46,7 +46,7 @@ resource "gitlab_group_variable" "example" {
 
 ### Optional
 
-- `access_level` (String) The access level for the group access token. Valid values are: `guest`, `reporter`, `developer`, `maintainer`.
+- `access_level` (String) The access level for the group access token. Valid values are: `guest`, `reporter`, `developer`, `maintainer`, `owner`.
 - `expires_at` (String) The token expires at midnight UTC on that date. The date must be in the format YYYY-MM-DD. Default is never.
 - `id` (String) The ID of this resource.
 

internal/provider/resource_gitlab_group_access_token.go

@@ -27,6 +27,7 @@ var validAccessLevels = []string{
 	"reporter",
 	"developer",
 	"maintainer",
+	"owner",
 }
 
 var _ = registerResource("gitlab_group_access_token", func() *schema.Resource {

internal/provider/resource_gitlab_group_access_token_test.go

@@ -48,6 +48,19 @@ func TestAccGitlabGroupAccessToken_basic(t *testing.T) {
 					}),
 				),
 			},
+			// Update the Group Access Token Access Level to Owner
+			{
+				Config: testAccGitlabGroupAccessTokenUpdateAccessLevel(testGroup.ID),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckGitlabGroupAccessTokenExists("gitlab_group_access_token.this", &gat),
+					testAccCheckGitlabGroupAccessTokenAttributes(&gat, &testAccGitlabGroupAccessTokenExpectedAttributes{
+						name:        "my new group token",
+						scopes:      map[string]bool{"read_repository": false, "api": true, "write_repository": false, "read_api": false},
+						expiresAt:   "2099-05-01",
+						accessLevel: gitlab.AccessLevelValue(gitlab.OwnerPermissions),
+					}),
+				),
+			},
 			// Add a CICD variable with Group Access Token value
 			{
 				Config: testAccGitlabGroupAccessTokenUpdateConfigWithCICDvar(testGroup.ID),
@@ -229,6 +242,18 @@ resource "gitlab_group_access_token" "this" {
 	`, groupId)
 }
 
+func testAccGitlabGroupAccessTokenUpdateAccessLevel(groupId int) string {
+	return fmt.Sprintf(`
+resource "gitlab_group_access_token" "this" {
+  name = "my new group token"
+  group = %d
+  expires_at = "2099-05-01"
+  access_level = "owner"
+  scopes = ["api"]
+}
+	`, groupId)
+}
+
 func testAccGitlabGroupAccessTokenUpdateConfigWithCICDvar(groupId int) string {
 	return fmt.Sprintf(`
 resource "gitlab_group_access_token" "this" {