Skip to content

Commit bdc93f0

Browse files
committed
resource/gitlab_group_label: Remove unnecessary large tests and cleanup import test
1 parent 8d034b7 commit bdc93f0

File tree

1 file changed

+2
-85
lines changed

1 file changed

+2
-85
lines changed

internal/provider/resource_gitlab_group_label_test.go

Lines changed: 2 additions & 85 deletions
Original file line numberDiff line numberDiff line change
@@ -53,53 +53,8 @@ func TestAccGitlabGroupLabel_basic(t *testing.T) {
5353
),
5454
},
5555
{
56-
Config: testAccGitlabGroupLabelLargeConfig(rInt),
57-
Check: resource.ComposeTestCheckFunc(
58-
testAccCheckGitlabGroupLabelExists("gitlab_group_label.fixme.20", &label),
59-
testAccCheckGitlabGroupLabelExists("gitlab_group_label.fixme.30", &label),
60-
testAccCheckGitlabGroupLabelExists("gitlab_group_label.fixme.40", &label),
61-
testAccCheckGitlabGroupLabelExists("gitlab_group_label.fixme.10", &label),
62-
testAccCheckGitlabGroupLabelAttributes(&label, &testAccGitlabGroupLabelExpectedAttributes{
63-
Name: "FIXME11",
64-
Color: "#ffcc00",
65-
Description: "fix this test",
66-
}),
67-
),
68-
},
69-
{
70-
Config: testAccGitlabGroupLabelUpdateLargeConfig(rInt),
71-
Check: resource.ComposeTestCheckFunc(
72-
testAccCheckGitlabGroupLabelExists("gitlab_group_label.fixme.20", &label),
73-
testAccCheckGitlabGroupLabelExists("gitlab_group_label.fixme.30", &label),
74-
testAccCheckGitlabGroupLabelExists("gitlab_group_label.fixme.40", &label),
75-
testAccCheckGitlabGroupLabelExists("gitlab_group_label.fixme.10", &label),
76-
testAccCheckGitlabGroupLabelAttributes(&label, &testAccGitlabGroupLabelExpectedAttributes{
77-
Name: "FIXME11",
78-
Color: "#ff0000",
79-
Description: "red label",
80-
}),
81-
),
82-
},
83-
},
84-
})
85-
}
86-
87-
// lintignore: AT002 // TODO: Resolve this tfproviderlint issue
88-
func TestAccGitlabGroupLabel_import(t *testing.T) {
89-
rInt := acctest.RandInt()
90-
resourceName := "gitlab_group_label.fixme"
91-
92-
resource.Test(t, resource.TestCase{
93-
PreCheck: func() { testAccPreCheck(t) },
94-
ProviderFactories: providerFactories,
95-
CheckDestroy: testAccCheckGitlabGroupLabelDestroy,
96-
Steps: []resource.TestStep{
97-
{
98-
Config: testAccGitlabGroupLabelConfig(rInt),
99-
},
100-
{
101-
ResourceName: resourceName,
102-
ImportStateIdFunc: getGroupLabelImportID(resourceName),
56+
ResourceName: "gitlab_group_label.fixme",
57+
ImportStateIdFunc: getGroupLabelImportID("gitlab_group_label.fixme"),
10358
ImportState: true,
10459
ImportStateVerify: true,
10560
},
@@ -235,41 +190,3 @@ resource "gitlab_group_label" "fixme" {
235190
}
236191
`, rInt, rInt, rInt)
237192
}
238-
239-
func testAccGitlabGroupLabelLargeConfig(rInt int) string {
240-
return fmt.Sprintf(`
241-
resource "gitlab_group" "foo" {
242-
name = "foo-%d"
243-
path = "foo-%d"
244-
description = "Terraform acceptance tests"
245-
visibility_level = "public"
246-
}
247-
248-
resource "gitlab_group_label" "fixme" {
249-
group = "${gitlab_group.foo.id}"
250-
name = format("FIXME%%02d", count.index+1)
251-
count = 100
252-
color = "#ffcc00"
253-
description = "fix this test"
254-
}
255-
`, rInt, rInt)
256-
}
257-
258-
func testAccGitlabGroupLabelUpdateLargeConfig(rInt int) string {
259-
return fmt.Sprintf(`
260-
resource "gitlab_group" "foo" {
261-
name = "foo-%d"
262-
path = "foo-%d"
263-
description = "Terraform acceptance tests"
264-
visibility_level = "public"
265-
}
266-
267-
resource "gitlab_group_label" "fixme" {
268-
group = "${gitlab_group.foo.id}"
269-
name = format("FIXME%%02d", count.index+1)
270-
count = 99
271-
color = "#ff0000"
272-
description = "red label"
273-
}
274-
`, rInt, rInt)
275-
}

0 commit comments

Comments
 (0)