Skip to content

Commit c802bf5

Browse files
jtymestimofurrer
andauthored
Apply suggestions from code review
Co-authored-by: Timo Furrer <[email protected]>
1 parent e3309d1 commit c802bf5

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

internal/provider/data_source_gitlab_group.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ var _ = registerDataSource("gitlab_group", func() *schema.Resource {
9292
Computed: true,
9393
},
9494
"prevent_forking_outside_group": {
95-
Description: "When enabled, users can not fork projects from this group to external namespaces",
95+
Description: "When enabled, users can not fork projects from this group to external namespaces.",
9696
Type: schema.TypeBool,
9797
Computed: true,
9898
},

internal/provider/resource_gitlab_group.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ var _ = registerResource("gitlab_group", func() *schema.Resource {
149149
Sensitive: true,
150150
},
151151
"prevent_forking_outside_group": {
152-
Description: "When enabled, users can not fork projects from this group to external namespaces",
152+
Description: "When enabled, users can not fork projects from this group to external namespaces.",
153153
Type: schema.TypeBool,
154154
Optional: true,
155155
Default: false,
@@ -237,7 +237,7 @@ func resourceGitlabGroupCreate(ctx context.Context, d *schema.ResourceData, meta
237237

238238
if (updateOptions != gitlab.UpdateGroupOptions{}) {
239239
if _, _, err = client.Groups.UpdateGroup(d.Id(), &updateOptions, gitlab.WithContext(ctx)); err != nil {
240-
return diag.Errorf("could not update group %q: %s", d.Id(), err)
240+
return diag.Errorf("could not update group after creation %q: %s", d.Id(), err)
241241
}
242242
}
243243

0 commit comments

Comments
 (0)