Allow disable/enable packages repository (#405)

* Bump go-gitlab to v.0.38.1

* feat: allow to enable/disable packages repository

Closes: #404

Author: jeremad

docs/data-sources/project.md

@@ -69,4 +69,6 @@ The following attributes are exported:
 
 * `archived` - Whether the project is in read-only mode (archived).
 
-* `remove_source_branch_after_merge` - Enable `Delete source branch` option by default for all new merge requests
+* `remove_source_branch_after_merge` - Enable `Delete source branch` option by default for all new merge requests
+
+* `packages_enabled` - Enable packages repository for the project.

docs/resources/project.md

@@ -78,6 +78,8 @@ The following arguments are supported:
 
 * `initialize_with_readme` - (Optional) Create master branch with first commit containing a README.md file.
 
+* `packages_enabled` - (Optional) Enable packages repository for the project.
+
 ## Attributes Reference
 
 The following additional attributes are exported:

gitlab/data_source_gitlab_projects.go

@@ -156,6 +156,7 @@ func flattenProjects(projects []*gitlab.Project) (values []map[string]interface{
 				"_links":                              flattenProjectLinks(project.Links),
 				"ci_config_path":                      project.CIConfigPath,
 				"custom_attributes":                   project.CustomAttributes,
+				"packages_enabled":                    project.PackagesEnabled,
 			}
 			values = append(values, v)
 		}
@@ -648,6 +649,10 @@ func dataSourceGitlabProjects() *schema.Resource {
 								Type: schema.TypeMap,
 							},
 						},
+						"packages_enabled": {
+							Type:     schema.TypeBool,
+							Computed: true,
+						},
 					},
 				},
 			},

gitlab/resource_gitlab_project.go

@@ -186,6 +186,11 @@ var resourceGitLabProjectSchema = map[string]*schema.Schema{
 		Type:     schema.TypeBool,
 		Optional: true,
 	},
+	"packages_enabled": {
+		Type:     schema.TypeBool,
+		Optional: true,
+		Default:  true,
+	},
 }
 
 func resourceGitlabProject() *schema.Resource {
@@ -230,6 +235,7 @@ func resourceGitlabProjectSetToState(d *schema.ResourceData, project *gitlab.Pro
 	d.Set("tags", project.TagList)
 	d.Set("archived", project.Archived)
 	d.Set("remove_source_branch_after_merge", project.RemoveSourceBranchAfterMerge)
+	d.Set("packages_enabled", project.PackagesEnabled)
 }
 
 func resourceGitlabProjectCreate(d *schema.ResourceData, meta interface{}) error {
@@ -252,6 +258,7 @@ func resourceGitlabProjectCreate(d *schema.ResourceData, meta interface{}) error
 		OnlyAllowMergeIfAllDiscussionsAreResolved: gitlab.Bool(d.Get("only_allow_merge_if_all_discussions_are_resolved").(bool)),
 		SharedRunnersEnabled:                      gitlab.Bool(d.Get("shared_runners_enabled").(bool)),
 		RemoveSourceBranchAfterMerge:              gitlab.Bool(d.Get("remove_source_branch_after_merge").(bool)),
+		PackagesEnabled:                           gitlab.Bool(d.Get("packages_enabled").(bool)),
 	}
 
 	if v, ok := d.GetOk("path"); ok {
@@ -429,6 +436,10 @@ func resourceGitlabProjectUpdate(d *schema.ResourceData, meta interface{}) error
 		options.RemoveSourceBranchAfterMerge = gitlab.Bool(d.Get("remove_source_branch_after_merge").(bool))
 	}
 
+	if d.HasChange("packages_enabled") {
+		options.PackagesEnabled = gitlab.Bool(d.Get("packages_enabled").(bool))
+	}
+
 	if *options != (gitlab.EditProjectOptions{}) {
 		log.Printf("[DEBUG] update gitlab project %s", d.Id())
 		_, _, err := client.Projects.EditProject(d.Id(), options)

gitlab/resource_gitlab_project_test.go

@@ -40,7 +40,8 @@ func TestAccGitlabProject_basic(t *testing.T) {
 		MergeMethod:                      gitlab.FastForwardMerge,
 		OnlyAllowMergeIfPipelineSucceeds: true,
 		OnlyAllowMergeIfAllDiscussionsAreResolved: true,
-		Archived: false, // needless, but let's make this explicit
+		Archived:        false, // needless, but let's make this explicit
+		PackagesEnabled: true,
 	}
 
 	defaultsMasterBranch = defaults
@@ -80,7 +81,8 @@ func TestAccGitlabProject_basic(t *testing.T) {
 						MergeMethod:                      gitlab.FastForwardMerge,
 						OnlyAllowMergeIfPipelineSucceeds: true,
 						OnlyAllowMergeIfAllDiscussionsAreResolved: true,
-						Archived: true,
+						Archived:        true,
+						PackagesEnabled: false,
 					}, &received),
 				),
 			},
@@ -151,6 +153,7 @@ func TestAccGitlabProject_willError(t *testing.T) {
 		MergeMethod:                      gitlab.FastForwardMerge,
 		OnlyAllowMergeIfPipelineSucceeds: true,
 		OnlyAllowMergeIfAllDiscussionsAreResolved: true,
+		PackagesEnabled: true,
 	}
 	willError := defaults
 	willError.TagList = []string{"notatag"}
@@ -249,6 +252,7 @@ func TestAccGitlabProject_transfer(t *testing.T) {
 		MergeMethod:                      gitlab.NoFastForwardMerge,
 		OnlyAllowMergeIfPipelineSucceeds: false,
 		OnlyAllowMergeIfAllDiscussionsAreResolved: false,
+		PackagesEnabled: true,
 	}
 
 	resource.Test(t, resource.TestCase{
@@ -534,8 +538,9 @@ resource "gitlab_project" "foo" {
   snippets_enabled = false
   container_registry_enabled = false
   lfs_enabled = false
-	shared_runners_enabled = false
-	archived = true
+  shared_runners_enabled = false
+  archived = true
+  packages_enabled = false
 }
 	`, rInt, rInt)
 }

go.mod

@@ -3,7 +3,7 @@ module github.com/gitlabhq/terraform-provider-gitlab
 require (
 	github.com/hashicorp/terraform-plugin-sdk v1.13.1
 	github.com/mitchellh/hashstructure v1.0.0
-	github.com/xanzy/go-gitlab v0.34.1
+	github.com/xanzy/go-gitlab v0.38.1
 )
 
 go 1.14

go.sum

@@ -192,8 +192,8 @@ github.com/ulikunitz/xz v0.5.5/go.mod h1:2bypXElzHzzJZwzH67Y6wb67pO62Rzfn7BSiF4A
 github.com/vmihailenco/msgpack v3.3.3+incompatible/go.mod h1:fy3FlTQTDXWkZ7Bh6AcGMlsjHatGryHQYUTf1ShIgkk=
 github.com/vmihailenco/msgpack v4.0.1+incompatible h1:RMF1enSPeKTlXrXdOcqjFUElywVZjjC6pqse21bKbEU=
 github.com/vmihailenco/msgpack v4.0.1+incompatible/go.mod h1:fy3FlTQTDXWkZ7Bh6AcGMlsjHatGryHQYUTf1ShIgkk=
-github.com/xanzy/go-gitlab v0.34.1 h1:Dtqla2gWIQIevfZVS6FY4qjgrKf+5LYLzW6XBNstGSw=
-github.com/xanzy/go-gitlab v0.34.1/go.mod h1:sPLojNBn68fMUWSxIJtdVVIP8uSBYqesTfDUseX11Ug=
+github.com/xanzy/go-gitlab v0.38.1 h1:st5/Ag4h8CqVfp3LpOWW0Jd4jYHTGETwu0KksYDPnYE=
+github.com/xanzy/go-gitlab v0.38.1/go.mod h1:sPLojNBn68fMUWSxIJtdVVIP8uSBYqesTfDUseX11Ug=
 github.com/zclconf/go-cty v1.0.0/go.mod h1:xnAOWiHeOqg2nWS62VtQ7pbOu17FtxJNW8RLEih+O3s=
 github.com/zclconf/go-cty v1.1.0/go.mod h1:xnAOWiHeOqg2nWS62VtQ7pbOu17FtxJNW8RLEih+O3s=
 github.com/zclconf/go-cty v1.2.1 h1:vGMsygfmeCl4Xb6OA5U5XVAaQZ69FvoG7X2jUtQujb8=