Remove skip-test checks and rely on build tags instead

Author: armsnyder

internal/provider/data_source_gitlab_branch_test.go

@@ -14,10 +14,8 @@ import (
 
 func TestAccDataGitlabBranch_basic(t *testing.T) {
 	rInt := acctest.RandInt()
-	testAccCheck(t)
 	project := testAccCreateProject(t)
 	resource.Test(t, resource.TestCase{
-		PreCheck:          func() { testAccPreCheck(t) },
 		ProviderFactories: providerFactories,
 		Steps: []resource.TestStep{
 			{

internal/provider/data_source_gitlab_group_membership_test.go

@@ -15,7 +15,6 @@ func TestAccDataSourceGitlabMembership_basic(t *testing.T) {
 	rInt := acctest.RandInt()
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:          func() { testAccPreCheck(t) },
 		ProviderFactories: providerFactories,
 		Steps: []resource.TestStep{
 			// Create the group and one member
@@ -48,16 +47,13 @@ func TestAccDataSourceGitlabMembership_basic(t *testing.T) {
 }
 
 func TestAccDataSourceGitlabMembership_pagination(t *testing.T) {
-	testAccCheck(t)
-
 	userCount := 21
 
 	group := testAccCreateGroups(t, 1)[0]
 	users := testAccCreateUsers(t, userCount)
 	testAccAddGroupMembers(t, group.ID, users)
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:          func() { testAccPreCheck(t) },
 		ProviderFactories: providerFactories,
 		Steps: []resource.TestStep{
 			{

internal/provider/data_source_gitlab_group_test.go

@@ -16,7 +16,6 @@ func TestAccDataSourceGitlabGroup_basic(t *testing.T) {
 	rString := fmt.Sprintf("%s", acctest.RandString(5)) // nolint // TODO: Resolve this golangci-lint issue: S1025: the argument is already a string, there's no need to use fmt.Sprintf (gosimple)
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:          func() { testAccPreCheck(t) },
 		ProviderFactories: providerFactories,
 		Steps: []resource.TestStep{
 			// Get group using its ID

internal/provider/data_source_gitlab_group_variable_test.go

@@ -12,12 +12,9 @@ import (
 )
 
 func TestAccDataSourceGitlabGroupVariable_basic(t *testing.T) {
-	testAccCheck(t)
-
 	testGroup := testAccCreateGroups(t, 1)[0]
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:          func() { testAccPreCheck(t) },
 		ProviderFactories: providerFactories,
 		Steps: []resource.TestStep{
 			{

internal/provider/data_source_gitlab_group_variables_test.go

@@ -12,16 +12,13 @@ import (
 )
 
 func TestAccDataSourceGitlabGroupVariables_basic(t *testing.T) {
-	testAccCheck(t)
-
 	testGroup := testAccCreateGroups(t, 1)[0]
 	testVariables := make([]*gitlab.GroupVariable, 0)
 	for i := 0; i < 25; i++ {
 		testVariables = append(testVariables, testAccCreateGroupVariable(t, testGroup.ID))
 	}
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:          func() { testAccPreCheck(t) },
 		ProviderFactories: providerFactories,
 		Steps: []resource.TestStep{
 			{

internal/provider/data_source_gitlab_instance_deploy_keys_test.go

@@ -11,7 +11,6 @@ import (
 )
 
 func TestAccDataSourceGitlabInstanceDeployKeys_basic(t *testing.T) {
-	testAccCheck(t)
 	testKey := "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQCi+ErxScCKIVqg2ZRJ6Mx2Yd/RTsh2DGyhUR8z8Iey4rpi1YOBlpTgjxxnSLy26J++Un/iWYDP8wMvEjXElkWz3z4I+Z3mfF3dv039FTCu+O17Mw20Ek4DJxdrKvOgul040sUG/ABVHo6DjqjokjoVJwzUrUmoOtbeMMD8hFN9bWdEVyTj18XQO8nvEe/VkbhCRhAlZC1l60fM07/7Tw83SV5UNAnBtOB+nfa3b24baO+Ijc4+PqYcBuUAF6DvhXW2gZPqf5wjDBJqlDlRTYDdHarMXZAKBpWfWj0gntbtEOM+Fnp6hS1HajaeveNSs6yQwgQEDN2boQnDuvXJ8Y7zW3YQKZp8z0uqWYJSIrYRKVEVYL7gDWL9NvdRV52d/RKPnE/BlL2chiAWBRCT8buQdjVtEPPoYbA1667PXZg6PI9yhCGEIjCj71XzPssA6VL/R7yUafsmNLsirWz9Uyh3HJWCcgNuO9mglP5nfFHIXSHQVhEUEYMfzv1iX5FrenU= test"
 	testKey2 := "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQDStVqW58VZ5afXFphIvu2JahndXslJZMkgWsNiYCNdk/NvrEbc4i7yZVoDPFQsbS9I6Ty1RMW7qy3KxJalMsVHcw8arCQFDxs/ka1NHGCUPl68t5ZxUOl900KRQ0lOzGnDQMqG/UUZdPw4CCmigTr6Z9ZBcD1fXAiUwbXR4tWrr5z9KWXC2HgF4WkIJUTIct7ilY1m9W0y79dI/+K8bZrurn3q2QK83pxqqWkLwvUsCxtlhMpwuyflyzyuz8xPZl2GlZgxeIpr68gsPHIzzWizibwFfbRYKCZO4wD0r7JCDOYs9KjcIPpCG6d3HUqijClgdQSBnLwHTdE04ZtdzO8akvy0hMzRCooI5TSc8IAHos53Gp9aaW92sPA8za+WRP6OSH6UsOW4N+iQc4jyl7/fckMSgIZlJouNqqV+P8iqIFJGs70Tj5L8G/m+P2lc3kcE4Vjmj+Fc0xG5+I/PsSOpcc6DfDfZdVDRe8yklYd/qC1jI89OCeqjxu3XcUGHj9s= test"
 	testProjectTwoKeys := testAccCreateProject(t)
@@ -32,7 +31,6 @@ func TestAccDataSourceGitlabInstanceDeployKeys_basic(t *testing.T) {
 	testAccCreateDeployKey(t, testProjectOneKey.ID, &canPushDeployKeyOptions)
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:          func() { testAccPreCheck(t) },
 		ProviderFactories: providerFactories,
 		Steps: []resource.TestStep{
 			{

internal/provider/data_source_gitlab_instance_variable_test.go

@@ -13,7 +13,6 @@ import (
 
 func TestAccDataSourceGitlabInstanceVariable_basic(t *testing.T) {
 	resource.Test(t, resource.TestCase{
-		PreCheck:          func() { testAccPreCheck(t) },
 		ProviderFactories: providerFactories,
 		Steps: []resource.TestStep{
 			{

internal/provider/data_source_gitlab_instance_variables_test.go

@@ -12,15 +12,12 @@ import (
 )
 
 func TestAccDataSourceGitlabInstanceVariables_basic(t *testing.T) {
-	testAccCheck(t)
-
 	testVariables := make([]*gitlab.InstanceVariable, 0)
 	for i := 0; i < 25; i++ {
 		testVariables = append(testVariables, testAccCreateInstanceVariable(t))
 	}
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:          func() { testAccPreCheck(t) },
 		ProviderFactories: providerFactories,
 		Steps: []resource.TestStep{
 			{

internal/provider/data_source_gitlab_project_issue_test.go

@@ -12,12 +12,9 @@ import (
 )
 
 func TestAccDataSourceGitlabProjectIssue_basic(t *testing.T) {
-	testAccCheck(t)
-
 	testProject := testAccCreateProject(t)
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:          func() { testAccPreCheck(t) },
 		ProviderFactories: providerFactories,
 		Steps: []resource.TestStep{
 			{

internal/provider/data_source_gitlab_project_issues_test.go

@@ -11,13 +11,10 @@ import (
 )
 
 func TestAccDataSourceGitlabProjectIssues_basic(t *testing.T) {
-	testAccCheck(t)
-
 	testProject := testAccCreateProject(t)
 	testIssues := testAccCreateProjectIssues(t, testProject.ID, 25)
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:          func() { testAccPreCheck(t) },
 		ProviderFactories: providerFactories,
 		Steps: []resource.TestStep{
 			{