resource/gitlab_pipeline_schedule: Use GET API to retrieve single resource instead of listing

Author: timofurrer

internal/provider/resource_gitlab_pipeline_schedule.go

@@ -98,41 +98,21 @@ func resourceGitlabPipelineScheduleRead(ctx context.Context, d *schema.ResourceD
 
 	log.Printf("[DEBUG] read gitlab PipelineSchedule %s/%d", project, pipelineScheduleID)
 
-	opt := &gitlab.ListPipelineSchedulesOptions{
-		Page:    1,
-		PerPage: 20,
-	}
-
-	found := false
-	for {
-		pipelineSchedules, resp, err := client.PipelineSchedules.ListPipelineSchedules(project, opt, gitlab.WithContext(ctx))
-		if err != nil {
-			return diag.FromErr(err)
-		}
-		for _, pipelineSchedule := range pipelineSchedules {
-			if pipelineSchedule.ID == pipelineScheduleID {
-				d.Set("description", pipelineSchedule.Description)
-				d.Set("ref", pipelineSchedule.Ref)
-				d.Set("cron", pipelineSchedule.Cron)
-				d.Set("cron_timezone", pipelineSchedule.CronTimezone)
-				d.Set("active", pipelineSchedule.Active)
-				found = true
-				break
-			}
-		}
-
-		if found || resp.CurrentPage >= resp.TotalPages {
-			break
+	pipelineSchedule, _, err := client.PipelineSchedules.GetPipelineSchedule(project, pipelineScheduleID, gitlab.WithContext(ctx))
+	if err != nil {
+		if is404(err) {
+			log.Printf("[DEBUG] PipelineSchedule %d in project %s does not exist, removing from state", pipelineScheduleID, project)
+			d.SetId("")
+			return nil
 		}
-
-		opt.Page = resp.NextPage
-	}
-	if !found {
-		log.Printf("[DEBUG] PipelineSchedule %d no longer exists in gitlab", pipelineScheduleID)
-		d.SetId("")
-		return nil
+		return diag.FromErr(err)
 	}
 
+	d.Set("description", pipelineSchedule.Description)
+	d.Set("ref", pipelineSchedule.Ref)
+	d.Set("cron", pipelineSchedule.Cron)
+	d.Set("cron_timezone", pipelineSchedule.CronTimezone)
+	d.Set("active", pipelineSchedule.Active)
 	return nil
 }