Update users datasource: improve tests

Author: Jordan Caussat

gitlab/data_source_gitlab_users_test.go

@@ -1,27 +1,114 @@
 package gitlab
 
 import (
-	"regexp"
+	"fmt"
 	"testing"
 
+	"github.com/hashicorp/terraform/helper/acctest"
 	"github.com/hashicorp/terraform/helper/resource"
 )
 
 func TestAccDataSourceGitlabUsers_basic(t *testing.T) {
+	rInt := acctest.RandInt()
+	rInt2 := acctest.RandInt()
+	user2 := fmt.Sprintf("user%[email protected]", rInt2)
+
 	resource.Test(t, resource.TestCase{
 		PreCheck:  func() { testAccPreCheck(t) },
 		Providers: testAccProviders,
 		Steps: []resource.TestStep{
-			resource.TestStep{
-				Config: testAccComputeLbIpRangesConfig,
+			{
+				Config: testAccDataSourceGitlabUsersConfig(rInt, rInt2),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("gitlab_user.foo", "name", "footest1"),
+					resource.TestCheckResourceAttr("gitlab_user.foo2", "name", "footest2"),
+				),
+			},
+			{
+				Config: testAccDataSourceGitlabUsersConfigSort(rInt, rInt2),
 				Check: resource.ComposeTestCheckFunc(
-					resource.TestMatchResourceAttr("data.gitlab_users.test",
-						"users.#", regexp.MustCompile("^[1-9]*$"))),
+					resource.TestCheckResourceAttr("data.gitlab_users.foo", "users.#", "2"),
+					resource.TestCheckResourceAttr("data.gitlab_users.foo", "users.0.email", user2),
+					resource.TestCheckResourceAttr("data.gitlab_users.foo", "users.0.projects_limit", "2"),
+				),
+			},
+			{
+				Config: testAccDataSourceGitlabUsersConfigSearch(rInt, rInt2),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("data.gitlab_users.foo", "users.#", "1"),
+					// resource.TestCheckResourceAttr("data.gitlab_users.foo", "users.0.email", user2),
+				),
 			},
 		},
 	})
 }
 
-const testAccComputeLbIpRangesConfig = `
-data "gitlab_users" "test" {}
-`
+func testAccDataSourceGitlabUsersConfig(rInt int, rInt2 int) string {
+	return fmt.Sprintf(`
+resource "gitlab_user" "foo" {
+  name             = "footest1"
+  username         = "listest%d"
+  password         = "test%dtt"
+  email            = "user%[email protected]"
+  projects_limit   = 3
+}
+
+resource "gitlab_user" "foo2" {
+  name             = "footest2"
+  username         = "listest%d"
+  password         = "test%dtt"
+  email            = "user%[email protected]"
+  projects_limit   = 2
+}
+	`, rInt, rInt, rInt, rInt2, rInt2, rInt2)
+}
+
+func testAccDataSourceGitlabUsersConfigSort(rInt int, rInt2 int) string {
+	return fmt.Sprintf(`
+resource "gitlab_user" "foo" {
+  name             = "footest1"
+  username         = "listest%d"
+  password         = "test%dtt"
+  email            = "user%[email protected]"
+  projects_limit   = 3
+}
+
+resource "gitlab_user" "foo2" {
+  name             = "footest2"
+  username         = "listest%d"
+  password         = "test%dtt"
+  email            = "user%[email protected]"
+  projects_limit   = 2
+}
+
+data "gitlab_users" "foo" {
+  sort = "desc"
+  search = "footest"
+  order_by = "name"
+}
+	`, rInt, rInt, rInt, rInt2, rInt2, rInt2)
+}
+
+func testAccDataSourceGitlabUsersConfigSearch(rInt int, rInt2 int) string {
+	return fmt.Sprintf(`
+resource "gitlab_user" "foo" {
+  name             = "footest1"
+  username         = "listest%d"
+  password         = "test%dtt"
+  email            = "user%[email protected]"
+  projects_limit   = 3
+}
+
+resource "gitlab_user" "foo2" {
+  name             = "footest2"
+  username         = "listest%d"
+  password         = "test%dtt"
+  email            = "user%[email protected]"
+  projects_limit   = 2
+}
+
+data "gitlab_users" "foo" {
+  search = "user%[email protected]"
+}
+	`, rInt, rInt, rInt, rInt2, rInt2, rInt2, rInt2)
+}