Skip to content

Commit e761bae

Browse files
authored
Merge pull request #1077 from PatrickRice-KSC/fix-lint-errors
Fix lint errors
2 parents d6fa315 + 21f6298 commit e761bae

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

internal/provider/data_source_gitlab_projects.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,6 @@ var _ = registerDataSource("gitlab_projects", func() *schema.Resource {
212212

213213
ReadContext: dataSourceGitlabProjectsRead,
214214

215-
// lintignore: S006 // TODO: Resolve this tfproviderlint issue
216215
Schema: map[string]*schema.Schema{
217216
"max_queryable_pages": {
218217
Description: "The maximum number of project results pages that may be queried. Prevents overloading your Gitlab instance in case of a misconfiguration.",
@@ -791,6 +790,9 @@ var _ = registerDataSource("gitlab_projects", func() *schema.Resource {
791790
Computed: true,
792791
Elem: &schema.Schema{
793792
Type: schema.TypeMap,
793+
Elem: &schema.Schema{
794+
Type: schema.TypeString,
795+
},
794796
},
795797
},
796798
"packages_enabled": {

internal/provider/data_source_gitlab_projects_test.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ import (
1212
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
1313
)
1414

15-
// lintignore: AT003 // TODO: Resolve this tfproviderlint issue
16-
func TestAccDataGitlabProjectsSearch(t *testing.T) {
15+
func TestAccDataGitlabProjects_search(t *testing.T) {
1716
projectName := fmt.Sprintf("tf-%s", acctest.RandString(5))
1817

1918
resource.Test(t, resource.TestCase{
@@ -52,8 +51,7 @@ func TestAccDataGitlabProjectsSearch(t *testing.T) {
5251
})
5352
}
5453

55-
// lintignore: AT003 // TODO: Resolve this tfproviderlint issue
56-
func TestAccDataGitlabProjectsGroups(t *testing.T) {
54+
func TestAccDataGitlabProjects_groups(t *testing.T) {
5755
projectName := fmt.Sprintf("tf-%s", acctest.RandString(5))
5856
groupName := fmt.Sprintf("tf-%s", acctest.RandString(5))
5957
parentGroupName := fmt.Sprintf("tf-%s", acctest.RandString(5))

0 commit comments

Comments
 (0)