instance_cluster/group_cluster: Suppress whitespace diff for kubernetes_ca_cert (#728)

* instance_cluster/group_cluster: Suppress whitespace diff for kubernetes_ca_cert

* Add strings import

Author: armsnyder

gitlab/resource_gitlab_group_cluster.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"log"
 	"strconv"
+	"strings"
 
 	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/validation"
@@ -79,6 +80,9 @@ func resourceGitlabGroupCluster() *schema.Resource {
 			"kubernetes_ca_cert": {
 				Type:     schema.TypeString,
 				Optional: true,
+				DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
+					return strings.TrimSpace(old) == strings.TrimSpace(new)
+				},
 			},
 			"kubernetes_authorization_type": {
 				Type:         schema.TypeString,

gitlab/resource_gitlab_group_cluster_test.go

@@ -242,7 +242,7 @@ resource gitlab_group_cluster "foo" {
   managed                       = "%s"
   kubernetes_api_url            = "https://123.123.123"
   kubernetes_token              = "some-token"
-  kubernetes_ca_cert            = "${trimspace(var.cert)}"
+  kubernetes_ca_cert            = var.cert
   kubernetes_authorization_type = "abac"
 }
 `, groupClusterFakeCert, rInt, rInt, rInt, m)
@@ -272,7 +272,7 @@ resource gitlab_group_cluster "foo" {
   domain                        = "example-new.com"
   kubernetes_api_url            = "https://124.124.124"
   kubernetes_token              = "some-token"
-  kubernetes_ca_cert            = "${trimspace(var.cert)}"
+  kubernetes_ca_cert            = var.cert
   kubernetes_authorization_type = "%s"
 }
 `, groupClusterFakeCert, rInt, rInt, rInt, authType)
@@ -313,7 +313,7 @@ resource gitlab_group_cluster "foo" {
   managed                       = "%s"
   kubernetes_api_url            = "https://123.123.123"
   kubernetes_token              = "some-token"
-  kubernetes_ca_cert            = "${trimspace(var.cert)}"
+  kubernetes_ca_cert            = var.cert
   kubernetes_authorization_type = "abac"
   management_project_id         = "${gitlab_project.cluster-management.id}"
 }

gitlab/resource_gitlab_instance_cluster.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"log"
 	"strconv"
+	"strings"
 
 	"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
 	"github.com/hashicorp/terraform-plugin-sdk/helper/validation"
@@ -74,6 +75,9 @@ func resourceGitlabInstanceCluster() *schema.Resource {
 			"kubernetes_ca_cert": {
 				Type:     schema.TypeString,
 				Optional: true,
+				DiffSuppressFunc: func(k, old, new string, d *schema.ResourceData) bool {
+					return strings.TrimSpace(old) == strings.TrimSpace(new)
+				},
 			},
 			"kubernetes_namespace": {
 				Type:     schema.TypeString,

gitlab/resource_gitlab_instance_cluster_test.go

@@ -232,7 +232,7 @@ resource gitlab_instance_cluster "foo" {
   managed                       = "%s"
   kubernetes_api_url            = "https://123.123.123"
   kubernetes_token              = "some-token"
-	kubernetes_ca_cert            = "${trimspace(var.cert)}"
+	kubernetes_ca_cert            = var.cert
   kubernetes_authorization_type = "abac"
 }
 `, instanceClusterFakeCert, rInt, m)
@@ -251,7 +251,7 @@ resource gitlab_instance_cluster "foo" {
   domain                        = "example-new.com"
   kubernetes_api_url            = "https://124.124.124"
   kubernetes_token              = "some-token"
-  kubernetes_ca_cert            = "${trimspace(var.cert)}"
+  kubernetes_ca_cert            = var.cert
   kubernetes_authorization_type = "%s"
 }
 `, instanceClusterFakeCert, rInt, authType)