resource/gitlab_project_badge: Add name attribute

Author: Leonardo Biffi

docs/resources/project_badge.md

@@ -24,6 +24,7 @@ resource "gitlab_project_badge" "example" {
   project   = gitlab_project.foo.id
   link_url  = "https://example.com/badge-123"
   image_url = "https://example.com/badge-123.svg"
+  name      = "badge-123"
 }
 ```
 
@@ -39,6 +40,7 @@ resource "gitlab_project_badge" "example" {
 ### Optional
 
 - `id` (String) The ID of this resource.
+- `name` (String) The name of the badge.
 
 ### Read-Only
 

examples/resources/gitlab_project_badge/resource.tf

@@ -6,4 +6,5 @@ resource "gitlab_project_badge" "example" {
   project   = gitlab_project.foo.id
   link_url  = "https://example.com/badge-123"
   image_url = "https://example.com/badge-123.svg"
+  name      = "badge-123"
 }

internal/provider/resource_gitlab_project_badge.go

@@ -41,6 +41,11 @@ var _ = registerResource("gitlab_project_badge", func() *schema.Resource {
 				Type:        schema.TypeString,
 				Required:    true,
 			},
+			"name": {
+				Description: "The name of the badge.",
+				Type:        schema.TypeString,
+				Optional:    true,
+			},
 			"rendered_link_url": {
 				Description: "The link_url argument rendered (in case of use of placeholders).",
 				Type:        schema.TypeString,
@@ -61,6 +66,7 @@ func resourceGitlabProjectBadgeCreate(ctx context.Context, d *schema.ResourceDat
 	options := &gitlab.AddProjectBadgeOptions{
 		LinkURL:  gitlab.String(d.Get("link_url").(string)),
 		ImageURL: gitlab.String(d.Get("image_url").(string)),
+		Name:     gitlab.String(d.Get("name").(string)),
 	}
 
 	log.Printf("[DEBUG] create gitlab project badge %q / %q", *options.LinkURL, *options.ImageURL)
@@ -114,6 +120,7 @@ func resourceGitlabProjectBadgeUpdate(ctx context.Context, d *schema.ResourceDat
 	options := &gitlab.EditProjectBadgeOptions{
 		LinkURL:  gitlab.String(d.Get("link_url").(string)),
 		ImageURL: gitlab.String(d.Get("image_url").(string)),
+		Name:     gitlab.String(d.Get("name").(string)),
 	}
 
 	log.Printf("[DEBUG] update gitlab project badge %s/%d", projectID, badgeID)
@@ -148,6 +155,7 @@ func resourceGitlabProjectBadgeDelete(ctx context.Context, d *schema.ResourceDat
 func resourceGitlabProjectBadgeSetToState(d *schema.ResourceData, badge *gitlab.ProjectBadge, projectID *string) {
 	d.Set("link_url", badge.LinkURL)
 	d.Set("image_url", badge.ImageURL)
+	d.Set("name", badge.Name)
 	d.Set("rendered_link_url", badge.RenderedLinkURL)
 	d.Set("rendered_image_url", badge.RenderedImageURL)
 	d.Set("project", projectID)

internal/provider/resource_gitlab_project_badge_test.go

@@ -29,6 +29,7 @@ func TestAccGitlabProjectBadge_basic(t *testing.T) {
 					testAccCheckGitlabProjectBadgeAttributes(&badge, &testAccGitlabProjectBadgeExpectedAttributes{
 						LinkURL:  fmt.Sprintf("https://example.com/badge-%d", rInt),
 						ImageURL: fmt.Sprintf("https://example.com/badge-%d.svg", rInt),
+						Name:     fmt.Sprintf("badge-%d", rInt),
 					}),
 				),
 			},
@@ -46,6 +47,7 @@ func TestAccGitlabProjectBadge_basic(t *testing.T) {
 					testAccCheckGitlabProjectBadgeAttributes(&badge, &testAccGitlabProjectBadgeExpectedAttributes{
 						LinkURL:  fmt.Sprintf("https://example.com/badge-%d", rInt),
 						ImageURL: fmt.Sprintf("https://example.com/badge-%d.svg", rInt),
+						Name:     fmt.Sprintf("badge-%d", rInt),
 					}),
 				),
 			},
@@ -83,6 +85,7 @@ func testAccCheckGitlabProjectBadgeExists(n string, badge *gitlab.ProjectBadge)
 type testAccGitlabProjectBadgeExpectedAttributes struct {
 	LinkURL  string
 	ImageURL string
+	Name     string
 }
 
 func testAccCheckGitlabProjectBadgeAttributes(badge *gitlab.ProjectBadge, want *testAccGitlabProjectBadgeExpectedAttributes) resource.TestCheckFunc {
@@ -95,6 +98,10 @@ func testAccCheckGitlabProjectBadgeAttributes(badge *gitlab.ProjectBadge, want *
 			return fmt.Errorf("got image_url %s; want %s", badge.ImageURL, want.ImageURL)
 		}
 
+		if badge.Name != want.Name {
+			return fmt.Errorf("got name %q; want %q", badge.Name, want.Name)
+		}
+
 		return nil
 	}
 }
@@ -136,8 +143,9 @@ resource "gitlab_project_badge" "foo" {
   project   = "${gitlab_project.foo.id}"
   link_url  = "https://example.com/badge-%d"
   image_url = "https://example.com/badge-%d.svg"
+	name      = "badge-%d"
 }
-	`, rInt, rInt, rInt)
+	`, rInt, rInt, rInt, rInt)
 }
 
 func testAccGitlabProjectBadgeUpdateConfig(rInt int) string {
@@ -155,6 +163,7 @@ resource "gitlab_project_badge" "foo" {
   project   = "${gitlab_project.foo.id}"
   link_url  = "https://example.com/badge-%d"
   image_url = "https://example.com/badge-%d.svg"
+	name      = "badge-%d"
 }
-	`, rInt, rInt, rInt)
+	`, rInt, rInt, rInt, rInt)
 }