Cleaned some code

Author: lyrixx

src/Gitonomy/Git/Exception/ReferenceNotFoundException.php

@@ -16,6 +16,6 @@ class ReferenceNotFoundException extends \InvalidArgumentException implements Gi
 {
     public function __construct($reference)
     {
-        parent::__construct(sprintf('Reference not found'));
+        parent::__construct(sprintf('Reference not found: "%s"', $reference));
     }
 }

src/Gitonomy/Git/ReferenceBag.php

@@ -168,7 +168,7 @@ public function resolveTags($hash)
         }
 
         $tags = array();
-        foreach ($this->references as $k => $reference) {
+        foreach ($this->references as $reference) {
             if ($reference instanceof Reference\Tag && $reference->getCommitHash() === $hash) {
                 $tags[] = $reference;
             }
@@ -188,14 +188,14 @@ public function resolveBranches($hash)
             $hash = $hash->getHash();
         }
 
-        $tags = array();
-        foreach ($this->references as $k => $reference) {
+        $branches = array();
+        foreach ($this->references as $reference) {
             if ($reference instanceof Reference\Branch && $reference->getCommitHash() === $hash) {
-                $tags[] = $reference;
+                $branches[] = $reference;
             }
         }
 
-        return $tags;
+        return $branches;
     }
 
     /**

tests/Gitonomy/Git/Tests/ReferenceTest.php

@@ -89,7 +89,7 @@ public function testResolve($repository)
         $resolved = $repository->getReferences()->resolve($commit->getHash());
 
         $this->assertEquals(1, count($resolved), "1 revision resolved");
-        $this->assertTrue($resolved[0] instanceof Tag, "Resolved object is a tag");
+        $this->assertTrue(reset($resolved) instanceof Tag, "Resolved object is a tag");
     }
 
     /**
@@ -101,7 +101,7 @@ public function testResolveTags($repository)
         $resolved = $repository->getReferences()->resolveTags($commit->getHash());
 
         $this->assertEquals(1, count($resolved), "1 revision resolved");
-        $this->assertTrue($resolved[0] instanceof Tag, "Resolved object is a tag");
+        $this->assertTrue(reset($resolved) instanceof Tag, "Resolved object is a tag");
     }
 
     /**
@@ -114,7 +114,7 @@ public function testResolveBranches($repository)
         $resolved = $repository->getReferences()->resolveBranches($master->getCommitHash());
 
         $this->assertEquals(1, count($resolved), "1 revision resolved");
-        $this->assertTrue($resolved[0] instanceof Branch, "Resolved object is a branch");
+        $this->assertTrue(reset($resolved) instanceof Branch, "Resolved object is a branch");
     }
 
     /**