remove StringHelper from command parsers

Author: alexandresalome

src/Gitonomy/Git/Parser/CommitParser.php

@@ -12,8 +12,6 @@
 
 namespace Gitonomy\Git\Parser;
 
-use Gitonomy\Git\Util\StringHelper;
-
 class CommitParser extends ParserBase
 {
     public $tree;
@@ -58,7 +56,7 @@ protected function consumeNameEmailDate()
             throw new \RuntimeException('Unable to parse name, email and date');
         }
 
-        $this->cursor += StringHelper::strlen($vars[1]);
+        $this->cursor += strlen($vars[1]);
 
         return array($vars[2], $vars[3], $vars[4]);
     }

src/Gitonomy/Git/Parser/DiffParser.php

@@ -14,7 +14,6 @@
 
 use Gitonomy\Git\Diff\File;
 use Gitonomy\Git\Diff\FileChange;
-use Gitonomy\Git\Util\StringHelper;
 use Gitonomy\Git\Repository;
 
 class DiffParser extends ParserBase
@@ -100,8 +99,8 @@ protected function doParse()
                 }
             }
 
-            $oldName  = $oldName === '/dev/null' ? null : StringHelper::substr($oldName, 2);
-            $newName  = $newName === '/dev/null' ? null : StringHelper::substr($newName, 2);
+            $oldName  = $oldName === '/dev/null' ? null : substr($oldName, 2);
+            $newName  = $newName === '/dev/null' ? null : substr($newName, 2);
             $oldIndex = preg_match('/^0+$/', $oldIndex) ? null : $oldIndex;
             $newIndex = preg_match('/^0+$/', $newIndex) ? null : $newIndex;
             $file = new File($this->repository, $oldName, $newName, $oldMode, $newMode, $oldIndex, $newIndex, $isBinary);

src/Gitonomy/Git/Parser/ParserBase.php

@@ -26,7 +26,7 @@ public function parse($content)
     {
         $this->cursor  = 0;
         $this->content = $content;
-        $this->length  = StringHelper::strlen($this->content);
+        $this->length  = strlen($this->content);
 
         $this->doParse();
     }
@@ -38,16 +38,16 @@ protected function isFinished()
 
     protected function consumeAll()
     {
-        $rest = StringHelper::substr($this->content, $this->cursor);
-        $this->cursor += StringHelper::strlen($rest);
+        $rest = substr($this->content, $this->cursor);
+        $this->cursor += strlen($rest);
 
         return $rest;
     }
 
     protected function expects($expected)
     {
-        $length = StringHelper::strlen($expected);
-        $actual = StringHelper::substr($this->content, $this->cursor, $length);
+        $length = strlen($expected);
+        $actual = substr($this->content, $this->cursor, $length);
         if ($actual !== $expected) {
             return false;
         }
@@ -60,18 +60,18 @@ protected function expects($expected)
     protected function consumeShortHash()
     {
         if (!preg_match('/([A-Za-z0-9]{7,40})/A', $this->content, $vars, null, $this->cursor)) {
-            throw new \RuntimeException('No short hash found: '.StringHelper::substr($this->content, $this->cursor, 7));
+            throw new \RuntimeException('No short hash found: '.substr($this->content, $this->cursor, 7));
         }
 
-        $this->cursor += StringHelper::strlen($vars[1]);
+        $this->cursor += strlen($vars[1]);
 
         return $vars[1];
     }
 
     protected function consumeHash()
     {
         if (!preg_match('/([A-Za-z0-9]{40})/A', $this->content, $vars, null, $this->cursor)) {
-            throw new \RuntimeException('No hash found: '.StringHelper::substr($this->content, $this->cursor, 40));
+            throw new \RuntimeException('No hash found: '.substr($this->content, $this->cursor, 40));
         }
 
         $this->cursor += 40;
@@ -85,29 +85,29 @@ protected function consumeRegexp($regexp)
             throw new \RuntimeException('No match for regexp '.$regexp);
         }
 
-        $this->cursor += StringHelper::strlen($vars[0]);
+        $this->cursor += strlen($vars[0]);
 
         return $vars;
     }
 
     protected function consumeTo($text)
     {
-        $pos = StringHelper::strpos($this->content, $text, $this->cursor);
+        $pos = strpos($this->content, $text, $this->cursor);
 
         if (false === $pos) {
             throw new \RuntimeException(sprintf('Unable to find "%s"', $text));
         }
 
-        $result = StringHelper::substr($this->content, $this->cursor, $pos - $this->cursor);
+        $result = substr($this->content, $this->cursor, $pos - $this->cursor);
         $this->cursor = $pos;
 
         return $result;
     }
 
     protected function consume($expected)
     {
-        $length = StringHelper::strlen($expected);
-        $actual = StringHelper::substr($this->content, $this->cursor, $length);
+        $length = strlen($expected);
+        $actual = substr($this->content, $this->cursor, $length);
         if ($actual !== $expected) {
             throw new \RuntimeException(sprintf('Expected "%s", but got "%s" (%s)', $expected, $actual, substr($this->content, $this->cursor, 10)));
         }