Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.

Commit df878a7

Browse files
author
Noah Lee
authored
Remove the Slack interaction (#275)
* Delete Chatops of Slack * Fix documents for Chatops * Remove `SLACK_SIGNING_SECRET` env
1 parent bc00580 commit df878a7

27 files changed

+31
-2414
lines changed

cmd/server/config.go

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,10 @@ type (
4848
}
4949

5050
Slack struct {
51-
SlackClientID string `split_words:"true"`
52-
SlackClientSecret string `split_words:"true"`
53-
SlackSigningSecret string `split_words:"true"`
54-
SlackUserScopes []string `split_words:"true" default:""`
55-
SlackBotScopes []string `split_words:"true" default:"commands,chat:write"`
51+
SlackClientID string `split_words:"true"`
52+
SlackClientSecret string `split_words:"true"`
53+
SlackUserScopes []string `split_words:"true" default:""`
54+
SlackBotScopes []string `split_words:"true" default:"commands,chat:write"`
5655
}
5756

5857
Webhook struct {
@@ -88,7 +87,7 @@ func (c *Config) isGithubEnabled() bool {
8887
}
8988

9089
func (c *Config) isSlackEnabled() bool {
91-
return c.SlackClientID != "" && c.SlackClientSecret != "" && c.SlackSigningSecret != ""
90+
return c.SlackClientID != "" && c.SlackClientSecret != ""
9291
}
9392

9493
func (c *Config) hasTLS() bool {

cmd/server/main.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@ func newChatConfig(c *Config) *server.ChatConfig {
123123
Type: server.ChatTypeSlack,
124124
ClientID: c.SlackClientID,
125125
ClientSecret: c.SlackClientSecret,
126-
Secret: c.SlackSigningSecret,
127126
BotScopes: c.SlackBotScopes,
128127
UserScopes: c.SlackUserScopes,
129128
}

docs/concepts/chatops.md

Lines changed: 0 additions & 7 deletions
This file was deleted.

docs/concepts/notification.md

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# Notification
2+
3+
Gitploy notifies users when deployments and reviews are created or updated. Now, Gitploy supports browser notification and Slack.
4+
5+
## Browser
6+
7+
Gitploy provides the browser notification to alert events as default. Almost modern browsers provide [notification API](https://developer.mozilla.org/ko/docs/Web/API/notification), but unfortunately, some browsers are not supported. To avoid browser compatibility, you can replace it with Slack.
8+
9+
*Note that if the notification doesn't work even though your browser provides it, you should check the setting that it is enabled or not.*
10+
11+
12+
## Slack
13+
14+
Slack is a popular messaging app for businesses globally. Gitploy supports Slack to notify events of deployments and reviews. You can figure out the Connect button on the settings page after integrating with Slack. Check [the documentation](../tasks/integration.md) for details.
15+
16+
Figure) Slack notification
17+
18+
![Slack Notification](../images/slack-notification.png)
-9.14 KB
Loading

docs/images/slack-deploy.png

-37.5 KB
Binary file not shown.

docs/images/slack-interactivity.png

-44.1 KB
Binary file not shown.

docs/images/slack-new-command.png

-32.5 KB
Binary file not shown.

docs/images/slack-notification.png

32.3 KB
Loading

docs/references/GITPLOY_SLACK_SIGNING_SECRET.md

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)