mount empty secrets

coryb · coryb · commit 0123d32ba0e4 · 2022-09-03T11:54:32.000-07:00
We should create the mount point for secret files even if the source
secret file is empty.  Otherwise it is hard to debug why secrets
are not showing up when requested in the LLB.  Currently they are just
silently ignored which was pretty confusing.

Signed-off-by: coryb &lt;cbennett@netflix.com&gt;
diff --git a/solver/llbsolver/mounts/mount.go b/solver/llbsolver/mounts/mount.go
@@ -258,7 +258,7 @@ func (mm *MountManager) getSecretMountable(ctx context.Context, m *pb.Mount, g s
 		}
 		return nil
 	})
-	if err != nil || dt == nil {
+	if err != nil {
 		return nil, err
 	}
 	return &secretMount{mount: m, data: dt, idmap: mm.cm.IdentityMapping()}, nil

Original file line number	Diff line number	Diff line change
`@@ -258,7 +258,7 @@ func (mm MountManager) getSecretMountable(ctx context.Context, m pb.Mount, g s`
`258`	`258`	`}`
`259`	`259`	`return nil`
`260`	`260`	`})`
`261`		`- if err != nil \|\| dt == nil {`
	`261`	`+ if err != nil {`
`262`	`262`	`return nil, err`
`263`	`263`	`}`
`264`	`264`	`return &secretMount{mount: m, data: dt, idmap: mm.cm.IdentityMapping()}, nil`