lint: fix issues with go 1.20

Signed-off-by: CrazyMax <[email protected]>

Author: crazy-max

cmd/buildkitd/debug.go

@@ -6,6 +6,7 @@ import (
 	"net/http"
 	"net/http/pprof"
 	"runtime"
+	"time"
 
 	"github.com/sirupsen/logrus"
 	"golang.org/x/net/trace"
@@ -36,7 +37,12 @@ func setupDebugHandlers(addr string) error {
 	if err != nil {
 		return err
 	}
+	server := &http.Server{
+		Addr:              l.Addr().String(),
+		Handler:           m,
+		ReadHeaderTimeout: time.Minute,
+	}
 	logrus.Debugf("debug handlers listening at %s", addr)
-	go http.Serve(l, m)
+	go server.ListenAndServe()
 	return nil
 }

frontend/gateway/container.go

@@ -293,7 +293,7 @@ type gatewayContainer struct {
 	cancel     func()
 }
 
-func (gwCtr *gatewayContainer) Start(ctx context.Context, req client.StartRequest) (client.ContainerProcess, error) {
+func (gwCtr *gatewayContainer) Start(_ context.Context, req client.StartRequest) (client.ContainerProcess, error) {
 	resize := make(chan executor.WinSize)
 	signal := make(chan syscall.Signal)
 	procInfo := executor.ProcessInfo{

solver/scheduler_test.go

@@ -22,6 +22,7 @@ import (
 )
 
 func init() {
+	rand.Seed(time.Now().UnixNano()) //nolint:staticcheck // Ignore SA1019. No way to get the automatically generated seed since Go 1.20.
 	if debugScheduler {
 		logrus.SetOutput(os.Stdout)
 		logrus.SetLevel(logrus.DebugLevel)
@@ -716,8 +717,6 @@ func TestHugeGraph(t *testing.T) {
 	t.Parallel()
 	ctx := context.TODO()
 
-	rand.Seed(time.Now().UnixNano())
-
 	cacheManager := newTrackingCacheManager(NewInMemoryCacheManager())
 
 	l := NewSolver(SolverOpt{
@@ -1036,8 +1035,6 @@ func TestSlowCache(t *testing.T) {
 	t.Parallel()
 	ctx := context.TODO()
 
-	rand.Seed(time.Now().UnixNano())
-
 	l := NewSolver(SolverOpt{
 		ResolveOpFunc: testOpResolver,
 	})
@@ -1117,8 +1114,6 @@ func TestParallelInputs(t *testing.T) {
 	t.Parallel()
 	ctx := context.TODO()
 
-	rand.Seed(time.Now().UnixNano())
-
 	l := NewSolver(SolverOpt{
 		ResolveOpFunc: testOpResolver,
 	})
@@ -1175,8 +1170,6 @@ func TestErrorReturns(t *testing.T) {
 	t.Parallel()
 	ctx := context.TODO()
 
-	rand.Seed(time.Now().UnixNano())
-
 	l := NewSolver(SolverOpt{
 		ResolveOpFunc: testOpResolver,
 	})
@@ -3047,8 +3040,6 @@ func TestCacheExportingMergedKey(t *testing.T) {
 func TestMergedEdgesLookup(t *testing.T) {
 	t.Parallel()
 
-	rand.Seed(time.Now().UnixNano())
-
 	// this test requires multiple runs to trigger the race
 	for i := 0; i < 20; i++ {
 		func() {
@@ -3102,8 +3093,6 @@ func TestMergedEdgesLookup(t *testing.T) {
 func TestCacheLoadError(t *testing.T) {
 	t.Parallel()
 
-	rand.Seed(time.Now().UnixNano())
-
 	ctx := context.TODO()
 
 	cacheManager := newTrackingCacheManager(NewInMemoryCacheManager())

source/http/httpsource.go

@@ -392,6 +392,9 @@ func (hs *httpSourceHandler) Snapshot(ctx context.Context, g session.Group) (cac
 	if err != nil {
 		return nil, err
 	}
+	defer func() {
+		_ = resp.Body.Close()
+	}()
 
 	ref, dgst, err := hs.save(ctx, resp, g)
 	if err != nil {

util/compression/compression.go

@@ -81,7 +81,7 @@ const (
 	mediaTypeImageLayerZstd         = ocispecs.MediaTypeImageLayer + "+zstd" // unreleased image-spec#790
 )
 
-var Default gzipType = Gzip
+var Default = Gzip
 
 func parse(t string) (Type, error) {
 	switch t {

util/testutil/integration/run.go

@@ -164,8 +164,8 @@ func Run(t *testing.T, testCases []Test, opt ...TestOpt) {
 
 	list := List()
 	if os.Getenv("BUILDKIT_WORKER_RANDOM") == "1" && len(list) > 0 {
-		rand.Seed(time.Now().UnixNano())
-		list = []Worker{list[rand.Intn(len(list))]} //nolint:gosec // using math/rand is fine in a test utility
+		rng := rand.New(rand.NewSource(time.Now().UnixNano())) //nolint:gosec // using math/rand is fine in a test utility
+		list = []Worker{list[rng.Intn(len(list))]}
 	}
 
 	for _, br := range list {