Skip to content

Commit 138ee4c

Browse files
crazy-maxtonistiigi
authored andcommitted
lint: InvalidBaseImagePlatform does not need specific docs
Signed-off-by: CrazyMax <[email protected]>
1 parent 92698a6 commit 138ee4c

File tree

6 files changed

+4
-50
lines changed

6 files changed

+4
-50
lines changed

frontend/dockerfile/dockerfile_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7232,7 +7232,6 @@ ENV foo=bar
72327232
{
72337233
RuleName: "InvalidBaseImagePlatform",
72347234
Description: "Base image platform does not match expected target platform",
7235-
URL: "https://docs.docker.com/go/dockerfile/rule/invalid-base-image-platform/",
72367235
Detail: fmt.Sprintf("Base image %s was pulled with platform %q, expected %q for current build", target, targetPlatform, runtime.GOOS+"/"+runtime.GOARCH),
72377236
Level: 1,
72387237
Line: 2,

frontend/dockerfile/docs/rules/_index.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,5 @@ $ docker build --check .
8484
<td><a href="./legacy-key-value-format.md">LegacyKeyValueFormat</a></td>
8585
<td>Legacy key/value format with whitespace separator should not be used</td>
8686
</tr>
87-
<tr>
88-
<td><a href="./invalid-base-image-platform.md">InvalidBaseImagePlatform</a></td>
89-
<td>Base image platform does not match expected target platform</td>
90-
</tr>
9187
</tbody>
9288
</table>

frontend/dockerfile/docs/rules/invalid-base-image-platform.md

Lines changed: 0 additions & 26 deletions
This file was deleted.

frontend/dockerfile/linter/docs/InvalidBaseImagePlatform.md

Lines changed: 0 additions & 18 deletions
This file was deleted.

frontend/dockerfile/linter/generate.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,10 @@ func listRules() ([]Rule, error) {
164164
}
165165
}
166166
}
167+
if rule.Name == "InvalidBaseImagePlatform" {
168+
// this rule does not have any specific documentation needed
169+
continue
170+
}
167171
if rule.URL == nil {
168172
inspectErr = errors.Errorf("URL not set for %q", rule.Name)
169173
return false

frontend/dockerfile/linter/ruleset.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ var (
128128
RuleInvalidBaseImagePlatform = LinterRule[func(string, string, string) string]{
129129
Name: "InvalidBaseImagePlatform",
130130
Description: "Base image platform does not match expected target platform",
131-
URL: "https://docs.docker.com/go/dockerfile/rule/invalid-base-image-platform/",
132131
Format: func(image, expected, actual string) string {
133132
return fmt.Sprintf("Base image %s was pulled with platform %q, expected %q for current build", image, actual, expected)
134133
},

0 commit comments

Comments
 (0)