Skip to content

Commit 1d44dd6

Browse files
authored
Merge pull request moby#5253 from profnandaa/tests-4485-part-2
tests: frontend/dockerfile: update integration tests for windows/wcow (part 4)
2 parents 24d04a7 + 13fefce commit 1d44dd6

File tree

5 files changed

+175
-52
lines changed

5 files changed

+175
-52
lines changed

frontend/dockerfile/dockerfile_outline_test.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,6 @@ FROM second
240240
}
241241

242242
func testOutlineDescribeDefinition(t *testing.T, sb integration.Sandbox) {
243-
integration.SkipOnPlatform(t, "windows")
244243
workers.CheckFeatureCompat(t, sb, workers.FeatureFrontendOutline)
245244
f := getFrontend(t, sb)
246245
if _, ok := f.(*clientFrontend); !ok {
@@ -251,10 +250,16 @@ func testOutlineDescribeDefinition(t *testing.T, sb integration.Sandbox) {
251250
require.NoError(t, err)
252251
defer c.Close()
253252

254-
dockerfile := []byte(`
253+
dockerfile := []byte(integration.UnixOrWindows(
254+
`
255255
FROM scratch
256256
COPY Dockerfile Dockerfile
257-
`)
257+
`,
258+
`
259+
FROM nanoserver
260+
COPY Dockerfile Dockerfile
261+
`,
262+
))
258263

259264
dir := integration.Tmpdir(
260265
t,

frontend/dockerfile/dockerfile_targets_test.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,6 @@ FROM second AS binary
125125
}
126126

127127
func testTargetsDescribeDefinition(t *testing.T, sb integration.Sandbox) {
128-
integration.SkipOnPlatform(t, "windows")
129128
workers.CheckFeatureCompat(t, sb, workers.FeatureFrontendTargets)
130129
f := getFrontend(t, sb)
131130
if _, ok := f.(*clientFrontend); !ok {
@@ -136,10 +135,16 @@ func testTargetsDescribeDefinition(t *testing.T, sb integration.Sandbox) {
136135
require.NoError(t, err)
137136
defer c.Close()
138137

139-
dockerfile := []byte(`
138+
dockerfile := []byte(integration.UnixOrWindows(
139+
`
140140
FROM scratch
141141
COPY Dockerfile Dockerfile
142-
`)
142+
`,
143+
`
144+
FROM nanoserver
145+
COPY Dockerfile Dockerfile
146+
`,
147+
))
143148

144149
dir := integration.Tmpdir(
145150
t,

0 commit comments

Comments
 (0)