Skip to content

Commit 23b9dd8

Browse files
authored
Merge pull request moby#4592 from jedevc/close-solver
chore: close solver resources on shutdown
2 parents 6bd8137 + 6337e81 commit 23b9dd8

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

control/control.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,11 +130,12 @@ func (c *Controller) Close() error {
130130
if err := c.opt.WorkerController.Close(); err != nil {
131131
rerr = multierror.Append(rerr, err)
132132
}
133-
134133
if err := c.opt.CacheStore.Close(); err != nil {
135134
rerr = multierror.Append(rerr, err)
136135
}
137-
136+
if err := c.solver.Close(); err != nil {
137+
rerr = multierror.Append(rerr, err)
138+
}
138139
return rerr
139140
}
140141

solver/llbsolver/solver.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,12 @@ func New(opt Opt) (*Solver, error) {
123123
return s, nil
124124
}
125125

126+
func (s *Solver) Close() error {
127+
s.solver.Close()
128+
err := s.sysSampler.Close()
129+
return err
130+
}
131+
126132
func (s *Solver) resolver() solver.ResolveOpFunc {
127133
return func(v solver.Vertex, b solver.Builder) (solver.Op, error) {
128134
w, err := s.resolveWorker()

0 commit comments

Comments
 (0)