Merge pull request moby#4928 from tonistiigi/validate-golangci-config

hack: add validation for golangci config

Author: crazy-max

.golangci.yml

@@ -1,7 +1,5 @@
 run:
   timeout: 30m
-  skip-files:
-    - ".*\\.pb\\.go$"
 
   modules-download-mode: vendor
 
@@ -70,6 +68,8 @@ linters-settings:
       G306: "0644"
 
 issues:
+  exclude-files:
+    - ".*\\.pb\\.go$"
   exclude-rules:
     - linters:
         - revive

docker-bake.hcl

@@ -147,6 +147,7 @@ target "lint" {
       { name = "labs", tags = "dfrunsecurity dfparents dfexcludepatterns", target = "golangci-lint" },
       { name = "nydus", tags = "nydus", target = "golangci-lint" },
       { name = "yaml", tags = "", target = "yamllint" },
+      { name = "golangci-verify", tags = "", target = "golangci-verify" },
       { name = "proto", tags = "", target = "protolint" },
       { name = "gopls", tags = "", target = "gopls-analyze" }
     ]

hack/dockerfiles/lint.Dockerfile

@@ -31,6 +31,12 @@ RUN --mount=target=/go/src/github.com/moby/buildkit \
   xx-go --wrap && \
   golangci-lint run --build-tags "${BUILDTAGS}" && \
   touch /golangci-lint.done
+  
+
+FROM base AS golangci-verify
+RUN --mount=target=/go/src/github.com/moby/buildkit \
+  golangci-lint config verify && \
+  touch /golangci-verify.done
 
 FROM base AS yamllint
 RUN --mount=target=/go/src/github.com/moby/buildkit \
@@ -89,5 +95,6 @@ EOF
 
 FROM scratch
 COPY --link --from=golangci-lint /golangci-lint.done /
+COPY --link --from=golangci-verify /golangci-verify.done /
 COPY --link --from=yamllint /yamllint.done /
 COPY --link --from=protolint /protolint.done /